Openfoodnetwork: Ghost icons on maps

[filipefurtad0]

Description

The icons of some existing enterprises are missing and don't appear on the map. So far, only was able to find two cases, each of them in staging-UK and -AU.

Newly created enterprises are displayed correctly.

Expected Behavior

Active and visible enterprises should be seen on the map with the appropriate icon.

Actual Behaviour

Some are not.

Steps to Reproduce

1. Go to staging-uk or staging-au.
2. Enable dev-tools (F12) and press Ctrl+Shift+C to enable the element picker.
3. Hover on the areas in the pics below, for the respective staging servers.
4. You should be able to find open enterprises, despite the missing icon.

Animated Gif/Screenshot

Staging-UK (in Firefox 75): Hub The Hacienda

Staging-AU (in Chrome): Hubs Nicoles Market / Avocado Producer / Carrot Producer

Workaround

None.

Severity

bug-s2: a non-critical feature is broken, no workaround

Your Environment

• Version used: v3.0 stable
• Browser name and version: Firefox 75 and Chrome 83.0.4103.97 (Official Build) (64-bit)
• Operating System and version (desktop or mobile): Desktop and Mobile

Possible Fix

Seems just the pic is not visible, everything else is there. Also, it seems to affect only UK and AU (it's not possible to check in FR though) - maybe related to #5622?

[luisramos0]

:+1: I am not sure this is an s2. I am not sure this should block the v3 release.

[filipefurtad0]

Thank you for the feedback.
I'm unsure on the extension/impact - hence the S2. But I agree not to block the release for this one @luisramos0. Should we downgrade it?

[Matt-Yorkley]

I'm assuming this is related to the new icon we added recently that shows "+1" where there are locations that overlap. I think this is related to #5622. Lets take a look again after #5624 is merged.

[sauloperez]

Yes, it really looks like an asset precompilation issue.

[Matt-Yorkley]

Thanks for spotting it @filipefurtad0 :muscle:

I think there might be some other bits like this with images and icons, we'll need to keep an eye out... :eyes:

[filipefurtad0]

Thanks @Matt-Yorkley :-)

I investigated a bit more and it seems indeed related to the +1 sign.

I've set these two hubs real close, in Sheffield - nrs. 149 and 151 Arundel St.:

It's possible to make these icons disappear if the address is set to be exactly the same: it should show the +1 icon.

I would downgrade to S2, as this is not a critical feature - would you agree?

[sigmundpetersen]

We can downgrade to S3 but it's still a v3-regression, right? If so I guess it stays in Dev Ready anyways

EDIT: Ah, I see Matt already moved to In Dev 🙂

[Matt-Yorkley]

I think we should knock out any quick fixes we can for regressions before the v3 rollout hits production :+1: