Openfoodnetwork: v3.4.4 Swiss Chard

Created on 3 Dec 2020  路  3Comments  路  Source: openfoodfoundation/openfoodnetwork

Steps:

The full process is described at https://github.com/openfoodfoundation/openfoodnetwork/wiki/Releasing.

Most helpful comment

Hey @andrewpbrett ,

The release looks good to go:
https://docs.google.com/document/d/1ckuuXjUNdm6Mc37VwUF3c-4Y_VBi9dauCvdZnAtuW5I/edit#

Only issue found is #6459 which is a regression, quite misleading one - may be an S3... Leaving this PR here for now - we'll check next week how to tackle this.

Other than that - thumbs up! :+1:

PS: Before deploying, I'd like to run some more detailed tests around Taxes. Another good reason not to move this to ready-to-go just yet :-)

All 3 comments

Hey @andrewpbrett ,

The release looks good to go:
https://docs.google.com/document/d/1ckuuXjUNdm6Mc37VwUF3c-4Y_VBi9dauCvdZnAtuW5I/edit#

Only issue found is #6459 which is a regression, quite misleading one - may be an S3... Leaving this PR here for now - we'll check next week how to tackle this.

Other than that - thumbs up! :+1:

PS: Before deploying, I'd like to run some more detailed tests around Taxes. Another good reason not to move this to ready-to-go just yet :-)

Ok! I went through the Taxes feature, I'd say this is looking very good. Tax-related test notes here (this document is WIP and related to the ongoing adjustments-task):
https://docs.google.com/document/d/1L_x35_si6aqjORLseLdBOaHht6D3Q8ny8h1NOiseq2g/edit#

Found #6462 and #6463 and, as mentioned above, #6459 - none of them seems to be a release blocker. I'm moving the release to Ready to Go - but I guess we'll have the chance to discuss these before deployment - for this reason, I'm adding the feedback label.

Deployed Tuesday December 8 馃憤

Was this page helpful?
0 / 5 - 0 ratings