Openfoodnetwork: [Release Blocker] Payment and shipping state displayed as NONE in the UI (after cash payment) -> causing Payment reports to break

Created on 27 Apr 2021 · 3Comments · Source: openfoodfoundation/openfoodnetwork

Description

It all looks quite similar to the previous issues #7021 and it's root cause #7003.

When placing backoffice orders, adding an uncaptured cash payment leaves the order with Payment and shipping state displaying as NONE, which then breaks the payments report onItemized Totals and Payment totals.

Expected Behavior

Orders should have the correct Payment and shipping states; relevant reports should render.

Actual Behaviour

Orders with uncaptured cash payments display Payment and shipping state displayed as NONE in the UI and break the payments report.

Steps to Reproduce

Create an order in the backoffice
On payment details: add a cash payment (don't capture it)
After clicking Update, notice the Payment and shipping state of the order changing to NONE
Visit /admin/reports/payments and select one of the report types Itemized Totals or Payment totals
Generating the report should trigger the snail

Animated Gif/Screenshot

After an un-captured cash payment (backoffice order):

After reaching this state, /admin/reports/payments and selecting: Itemized Totals and Payment totals:

Workaround

Capturing the payment? One would need to be aware of this...

Severity

s2 - Blocking the release, as discussed here.

Your Environment

Version used: v3.6.8
Browser name and version: Firefox
Operating System and version (desktop or mobile): Desktop Ubuntu 20.04

Possible Fix

bug-s2

Source

filipefurtad0

All 3 comments

Just to clarify; it's only backoffice orders that are affected?

Matt-Yorkley on 27 Apr 2021

👍1

Yes, placing cash orders through the shopfront displays the order states as before, even before capturing the payment. I found no scenario in which this is affecting shopfront orders...

filipefurtad0 on 27 Apr 2021

👍1