Openfoodnetwork: Some transifex translations are not going through properly on a front end onboarding page

[myriamboure]

Description

I changed lots of transifex strings last week, before Kristina prepared the new release. They all went through apart in two places (was done at the same time, before some that went through so it's not a question of timing.

Problem 1:

Modification made in Transifex:

What I still view in production:

This is really annoying as there is no more logic in the text, as all the changes were consistent together, but now we say contradictory things on the same page, cause I changed quite deeply the meaning of the concerned translation.
And it's a touchy stage, onboarding stage. It would be great to fix quickly...

The concerned key is registration.steps.about.success

Problem 2:
Within the admin panel, "enterprise" menu, if I want to change the package of the enterprise (column "package" in the table), none of the translations I made went through, they are still the old ones for all producers and non-producers packages.

Example :
"Hub shop" package was translated since 8 days ago by "Boutique hub", and 8 days ago I changed for "Boutique multi-producteurs"

But in production, I still see the old translation:

The concerned keys are all the key containing 'js.admin.panels.enterprise_package', none of the package descriptions here have taken the new translations.

Severity

For France this translation issue would be s2 IMO... but I guess it won't be that prioritory for global... so I'm putting S3 (@RachL you can check what you think)

• Version used: 2.5.0 on French production

[luisramos0]

hey Myriam, you can save and check this URL to see what’s in the app: https://github.com/openfoodfoundation/openfoodnetwork/blob/master/config/locales/fr.yml
in this page you can also filter by version and see how the translation was in that version
I did this now and I confirm the translation is in the app in version 2.5.0
I just confirmed the translation in on the FR production server as well.

[luisramos0]

ok, the translations are there on the server but because these are javascript (browser side) translations, that is not enough.
The translations file on the JS side is not up to date. It was not updated.
I think it indicates a problem in asset compilation?

I thought of the introduction of mini_racer in #4287 but this PR has not been released yet...

This problem can be reproduced in staging FR.

[myriamboure]

@RachL for priorization process see Luis comment in Slack: "if not S2, at least a good candidate for top 5 S3s".
I would vote for s2 of course as it's pretty annoying for France as first onboarding screens are impacted... but you see with all the priorities.

[luisramos0]

in the last delivery train catch up we agreed this is an S2

[luisramos0]

oops, I staged master to staging FR and the problem is not there anymore. I don't understand why.
I think the best/faster solution is to prepare another release and see if the problem persists...

[luisramos0]

I temporarily upgraded to S1 as I thought js was not being updated (the JS bundle file in FR production is from August 30th). I then confirmed the JS code has not changed since August.
so, it's only a translations problem. we keep S2.

It looks like that if the JS code is not updated, the js bundle is not updated and the new translations are not picked up.
Maybe there's some i18n-js config we could change to achieve this but I have not managed to find it.
According to my change and tests in #538 the problem is fixed if we run assets:clean before assets:precompile (so that the new translations are always included in the JS bundle).