Openfoodnetwork: Customers: columns need to be sortable - nothing happening on click

Created on 4 Jun 2015  路  3Comments  路  Source: openfoodfoundation/openfoodnetwork

image

bug-s4 good first issue

All 3 comments

From memory, this is a scoping issue. The sorting was working but then I moved the ColumnsCtrl (where the sorting parameters are stored) so that it only wrapped the columns header elements. That broke everything because the ngRepeat directive for listing customers no longer has access to the sorting parameters.

I think if we just move the predicate and reverse parameters from ColumnsCtrl and into a $scope.sorting object on a higher scope (customersCtrl in this instance) that should pretty much fix the problem...

I am able to reproduce this bug, and would like to work on it. I have already gone through contribution guidelines, and will submit a PR within the day.

Hey @kristinalim ! Welcome to the OFN community :-) Please ask on Slack if you have any question !

Was this page helpful?
0 / 5 - 0 ratings