Openfoodnetwork: Update the language_name: key for IT locale file

Created on 4 Oct 2018  路  13Comments  路  Source: openfoodfoundation/openfoodnetwork

The language_name key should provide the name of the language itself.
I can see that in IT locale file, it is set as 'Inglese' when I think it should be 'Italiano', https://github.com/openfoodfoundation/openfoodnetwork/blob/master/config/locales/it.yml#L2.
Tell me if any issue.

bug-s3

All 13 comments

I'm wondering if that issue shouldn't be in the OFN-install repo? We hit that issue when implementing multilingual switching French - Italiano on the French instance, apparently @pacodelaluna had to do some manual hack on production. @sauloperez @luisramos0 @Matt-Yorkley do you see what the issue can be that we need to fix?

Hello, @sigmundpetersen is right.
The "inglese" issue is a translation in transifex, you can look for key:language_name and change the translation from Inglese to Italiano.
Closing. Please reopen if there's something I missed.

Oh yes, thanks @luisramos0 I didn't tell the italian translator about paying attention to that specific translation... anyway, I changed it @pacodelaluna so if we push again the italian translation from transifex into OFN and redo the process "Italiano" should automatically be there now. But we need to wait for next release to check that as we need to integrate translations into master to verify it solved the issue. But it should do.

Of course it could be fixed into Transiflex, but after it needs to be merged into the master branch, that's why I created the ticket here.
Still not solved by the way.

oh, I see you meant to create the issue to correct the translation in transifex and then merge it. I am not sure we create issues for that kind of translation issue. I will reopen so we can track this specific one.

I dont think FR was updated on the last releasse. I think we need to update the transifex process. A manual update/PR of all languages in every release is probably the best/easiest process.

Ping @mkllnk for feedback on the transifex process and the way forward on this specific issue

I agree. Manually pulling all translations when releasing fits our current process much better. The automatic Transifex integration hasn't been working well for us.

@mkllnk Ok, it is an option yes, and both options (merge one and direct pull one) can help to have better results. We could even add a recipe on ofn-install to proceed this automatically.

Can we close this now @mkllnk as the manual Transifex process is written down?
Should we also create an issue in ofn-install repo what @pacodelaluna suggests, to pull latest translations with ansible on every deploy?

Yes, I think we can close it now.

And yes, a new issue would be good. I would make it a separate playbook to start with, because by pulling the translations the deploy is not deterministic any more. The result depends on Transifex instead of the code. And if we automate it, we should only do it when we deploy master. Otherwise we will have a mismatch between the code and the translations.

Did someone open that new issue? @pacodelaluna as you suggested it do you want to open it? :-)

Was this page helpful?
0 / 5 - 0 ratings