Openfoodnetwork: Numbers do not overwrite when shopping in Explorer

[MagsHall]

On UK production, when shopping if I enter a quantity to purchase in the box the default 0 is not overwritten. I have to delete this 0 and enter the quantity I want, or risk purchasing a multiple of 10!

This is only occurring in Windows Explorer 11 and not on other browsers.

[stveep]

This seems to be an incompatibility with Angular and IE11. I came up with a fix that just ensures the existing text is highlighted when you click inside the box. It looks a bit uglier but that can be fixed with some CSS targeted at these boxes, as long as this solves the original problem.

Please test that it doesn't break anything on other browsers.

[Aside] I think the original problem only occurs the first time a box is clicked. It might be due to the ng-pristine/untouched attributes in some way but I couldn't figure out exactly why.

[MagsHall]

@stveep Are the changes on the staging server? I can't see any difference on production.

[lin-d-hop]

@MagsHall If you need something on staging best to give @OliverUK a shout.

[stveep]

I have just put it on staging.

On 31 January 2017 at 15:20, Lynne [e-mail] wrote:

@MagsHall https://github.com/MagsHall If you need something on staging
best to give @OliverUK https://github.com/OliverUK a shout.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openfoodfoundation/openfoodnetwork/issues/1417#issuecomment-276392066,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABQPmx79XWeqt-Q1TuD6P3OpJLHxeIh-ks5rX1EugaJpZM4LtorQ
.

[MagsHall]

So all looks fine on staging when browsing in Chrome, but products are not loading on the shopfront when I try to browse in IE11

[OliverUK]

I'm afraid I don't have IE, so can't help test this one.

[enricostano]

Does OFN has a "kind of official" supported browsers list somewhere?

[daniellemoorhead]

Reopened this @lin-d-hop as @NickWeir63 has offered to test on IE on the PR #1425. If you'd rather keep it closed then feel free to reclose this plus the PR.

Does OFN has a "kind of official" supported browsers list somewhere?

@enricostano not as far as I'm aware.

[RachL]

The new design has fixed this one 🎉