Online-go.com: Site doesn't load when localStorage is disabled

[pelevesque]

Summary

The site used to work in safari on my iphone 5s. It no longer does. After loading, it just shows a completely white page.

---

anoek: This is caused by the fact that safari in private mode doesn't allow the use of localStorage.

Environment

• Hardware: iphone 5s
• Operating system: iOS 10.1.1 (14B100)
• Browser: Safari
• Browser Version: Not sure. The one with iOS 10.1.1

Steps To Reproduce:

1. Load site (with localStorage disabled, eg with safari in private browsing mode)
2. You'll get a blank page.

[anoek]

Can you take some screenshots of any errors you see on the debug console? I've never tried this, but perhaps these instructions will help for getting to that information: https://www.lifewire.com/activate-the-debug-console-in-safari-445798

[mark5000]

I could not reproduce the white screen on an iPhone 5s. However, the interface leaves something to be desired. Portrait mode is pretty much unusable.

Landscape mode is better, although there's overlap all over the place.

[weej]

My Windows phone 8.1 also looks like this image, with overlapping text.

[anoek]

Yep, all that is related to https://github.com/online-go/online-go.com/issues/34 - basically we "just" need to make our table widget and the game list widget collapse nicely on mobile (and probably something on the overview page to fix that overlapping issue as well)

[pelevesque]

I get these 3 errors using web inspector with my iphone 5s.

[anoek]

@pelevesque Interesting, that looks like local storage is disabled for some reason. According to http://stackoverflow.com/questions/21159301/quotaexceedederror-dom-exception-22-an-attempt-was-made-to-add-something-to-st safari blocks local storage when in Private Browsing Mode, are you by any chance in private browsing mode?

[pelevesque]

Yes, I was in private browsing mode. The site works now that I removed it. Thanks.

[anoek]

Cool, closing this issue then and tracking the mobile layout stuff in https://github.com/online-go/online-go.com/issues/34

[anoek]

Actually keeping open so we can make a patch to more gracefully handle this situation. (We don't need to hard error.. we won't be able to store any settings, but folks should be able to log in and play just fine in private mode)

[blamarche]

What should be an simple fix is on the page init set window.localStorage if its undefined to a shell object with the same key functions. Edit: Now that I look at the error closely seems its a quota error, so perhaps a wrapper around localStorage.