Oni: Fuzzy finder highlighting would look better with bold instead of underlining

Created on 10 Mar 2018  路  3Comments  路  Source: onivim/oni

I find the underlining of separate letters a bit hard on the eye. It obfuscates the words a bit.

Let's compare how VSCode looks vs. how Oni looks:

capture d ecran 2018-03-10 a 18 00 43

capture d ecran 2018-03-10 a 18 00 51

I think bolding the matches would look a bit more polished

bug help wanted

Most helpful comment

Sublime Text bolds + uses another color:
screenshot 2018-03-13 22 37 36

All 3 comments

馃憤 , I'm open to changing this

If someone is up for taking a look at this - the component that handles the highlighting is around here:
https://github.com/onivim/oni/blob/3c88c847e3c55ac0f23bb945c9709deeb9021d02/browser/src/UI/components/HighlightText.tsx#L42

Sublime Text bolds + uses another color:
screenshot 2018-03-13 22 37 36

Seems like this is fixed in the latest release.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

TalAmuyal picture TalAmuyal  路  3Comments

dlee picture dlee  路  3Comments

grz8 picture grz8  路  3Comments

zxiest picture zxiest  路  3Comments

magopian picture magopian  路  3Comments