Oni: "Oh no!" error after loading a session

[hoschi]

I use https://github.com/vim-ctrlspace/vim-ctrlspace for session loading. Which worked before, but now I get an error:

[hoschi]

Seems to happen when there is only one buffer in a tab?!

[hoschi]

I also get this every once in a while (5 times this day, I believe) when I hit ,tc which is mapped to:
nmap <Leader>tc :tab split<cr>

[badosu]

Maybe we can list the extensions that are not working well with Oni while this issue is not resolved.

[hoschi]

:tab split is not a plugin, I don't think it has to do with ctrl-space itself.

[badosu]

Seems like a core Oni issue then, is it reproducible for you without loading init.vim?

[hoschi]

:tabclose also breaks Oni. I switch now to nvim as with that much various crashes and error popups I can't work.

@badosu yes, happens without init.vim aswell

[CrossR]

@hoschi , have you got a repro for this? I'm trying to have a look into it, but I'm struggling to get it to happen for me.

[hoschi]

I got it after 5mins with repeating this steps:

• open a file with "ctrl+p"
• open another file
• :tab split
• open another file
• open another file
• :tab split
• ...

I'm on 44e162d359c6b2a669e5d6

[CrossR]

Yep, repro'd it and got it sorted.
Think its a stupid error of mine for not checking if the input was an array before running find. Sorry!

Should also fix #1588 as far as I can tell, just pushing it now so the CI tests can run.

[hoschi]

Thanks for looking into it @CrossR
I update tomorrow morning and test it.

[badosu]

@hoschi Not sure if it would have avoided this specific error, but using the tagged released versions has proven stable for the last 3 months for day-to-day work to me.

[hoschi]

As I post several bugs after in depth testing after an update, I can skip the question "it is fixed in master" right away using master instead of stable.

[hoschi]

I try to update when a stable version was released, but most of the time it doesn't fit in my schedule :disappointed:

[hoschi]

Seems to be fixed with #1590
I'll test it this day and close this and #1588 if it doesn't crash anymore.

[hoschi]

No crash yesterday.