Ombi: Bug: Weekly limit number above 1 only counts as 1.

[Rsslone]

I have a weekly limit set to 3 but the user can only request 1 title before being given the message about weekly limit has been reached. I've checked the database and it shows only 1 request.
http://puu.sh/qdYID/6085c2cd61.png
I've tried other values above 1 and it still counts as 1.

Plex Requests.Net Version:

1.8.4

Operating System:

Win 8.1

[tidusjar]

Well that sucks!
I'll take a look when I get home from work.

[Rsslone]

You're the man. Is there anything I can preemptively provide you to help you solve the problem?

[tidusjar]

If you are willing, could take a copy of your Plex requests database (change the admin password so I can log in) and send it to me?

That way I have your exact settings?

[email protected]

On 25 Jul 2016, at 5:31 pm, Ryan [email protected] wrote:

You're the man. Is there anything I can preemptively provide you to help you solve the problem?

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.

[Rsslone]

Sent. Username is "Rsslone"

[tidusjar]

Found it. Was a silly mistake in the logic.

[Rsslone]

Sweet! ETA on release? Am I able to patch it myself?

[tidusjar]

Not sure about the next release, soonish. Just need to get the ability to select your own TV Episodes finished up.

You can run the dev build if you wish? But the selecting TV Episodes might not be 100% stable

[Rsslone]

How do I switch to the dev branch? I tried using git to checkout but it didn't work.

Excuse my noobness.

[tidusjar]

You will need the compiled version, it's here: https://ci.appveyor.com/project/tidusjar/requestplex/build/artifacts

[Rsslone]

So the previous issue is fixed but a new one popped up. Not sure if you're aware of it but the request limit is that number +1. So a request limit of 3 would allow 4 requests, Limit of 2 would allow 3.. and so on.

[tidusjar]

Ah ok. I'll fix that when I get home.

On 26 Jul 2016, at 1:13 pm, Ryan [email protected] wrote:

So the previous issue is fixed but a new one popped up. Not sure if you're aware of it but the request limit is that number +1. So a request limit of 3 would allow 4 requests, Limit of 2 would allow 3.. and so on.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.

[tidusjar]

Fixed! Plus added some unit test to make sure the code that does the check doesn't break in the future.

[Rsslone]

Confirmed fixed. Great work!

[tidusjar]

Haha that was fast! I'll push out a full release as soon as I can finish the Episode stuff and get someone to test it.

[Rsslone]

Yeah XD If you can't find someone to test it, I'm a good guinea pig.

[tidusjar]

I'll add you into the Gitter testers channel :dancers: