Notepad3: Unexpected CRLF correction

[RomanLT]

I have textfile in UTF8 where there are CR and CRLF. I say "not" when NP3 asks to normalize it where opening. OK yet.
Then I need to change the codepage. Doubleclick on "Unicode (UTF-8)" at bottom line to calling "Encoding" window. And this moment all my CR turn into CRLF (and my data - in a squash).
https://yadi.sk/i/c7SbA-91rB0ZJQ
https://yadi.sk/i/juE7oqxQl0u0vw

[RaiKoHoff]

Sorry - wrong counting of Status Bar segments for single-click (EOL Segment referenced).
But even this should popup a Requester to ask for change.
(Strange, that this has not been triggered earlier - the bug is their for a long time)

[RaiKoHoff]

No really a bug (wrong segment number retrieved).
Desired behavior:

1. File has inconsistent Line-Ends:
   
   
   
   • Single-Click on EOL-Mode status-bar segment -> ask to correct all EOLs to current mode
   
   
2. File has consistent Line-Ends:
   
   
   
   • Single-Click on EOL-Mode status-bar segment -> do nothing
   
   
   • Double-Click on EOL-Mode status-bar segment -> toggle through EOL Modes ( ... -> CR+LF -> CR -> LF -> CR+LF -> ...)
   
   

[hpwamr]

Hello @RaiKoHoff ,

I confirm the bug. 🤔

Tested with this file : Incons_Line_Endings_Source.txt

Just ONE click on "Unicode 'UTF-8) Signature" change ALL CR and LF to CR+LF without warning ! 😬

[RaiKoHoff]

Fix merged!

[hpwamr]

Fix merged!

OK, I will compile it. 👍

[hpwamr]

Hello @RaiKoHoff ,
The warning dialogbox contains only "Windows (CR+LF)"
I suggest to add" Do yo want to normalize the line endings?"

[hpwamr]

Hello @RomanLT ,

Feel free to test the "BETA/RC" version "Notepad3Portable_5.20.819.3_beta.paf" or higher, see below or issue #1129.

• Notepad3Portable_5.20.819.3_beta.paf.exe.7z -s

The "Notepad3Portable BETA/RC paf" version can be used with or without ".7z" extension.
To update the "Notepad3 Setup" version with the latest features/fixes from the "BETA/RC" version, see issue #1105.

Also, feel free to test the "BETA/RC" version "Notepad3_5.20.813.1_Setup_beta" or higher, see below or issue #1129.

• Notepad3_5.20.813.1_Setup_beta.exe.7z -s
• Notepad3_5.20.813.1_x86_Setup_beta.exe.7z -s

Comments and suggestions are welcome... 😃

[craigo-]

@hpwamr, a couple of the workupload.com links in the beta/rc channel issue (#1129) need attention:

[hpwamr]

a couple of the workupload.com links in the beta/rc channel issue (#1129) need attention:

Hello @craigo- ,
It's now fixed, many thanks for reporting the issues ! 👍 😃

[RomanLT]

Checking version "Notepad3Portable_5.20.819.3_beta.paf"
Seems the problem is out. All my CRs stay untouсhed in that case.
Thanks!
And yes, the question window (https://github.com/rizonesoft/Notepad3/issues/2681#issuecomment-676466188) shoud be a bit more informative ;)

[hpwamr]

Hello @RomanLT ,
Thanks for the reporting.

shoud be a bit more informative

It will be fixed with the next Beta. 👍