Notepad3: Insert AutoHotkey commands start case
I love the fact that I can use Np3 to autocomplete AutoHotkey commands (missed that in Np2-mod), but at the same time I can't, because the commands will all be inserted all-lowercase, not start case.
Apart from the fact that all AutoHotkey documentation uses start case for it's commands and variables (e.g. A_LoopRegTimeModified), it's especially important for readability of the "longer" almost sentence-like commands it includes.
Is it possible to include these command with the proper letter case?
For reference, here you can find the official syntax highlighting for editors and here's the source of an also Scintilla-based editor SciTE4AutoHotkey.
ltGuillaume
All 19 comments
@ltGuillaume : If you like, you can provide a source code contribution:
AHKL Lexer source code for Keywords: (https://github.com/rizonesoft/Notepad3/blob/master/src/StyleLexers/styleLexAHKL.c)
Feel free to adapt, extent and complete the lists (be aware of the space at the end of the lists).
Maybe @hpwamr will help you, if you want to make a PullRequest(PR) or just send the changed file.
RaiKoHoff
on 16 Sep 2019
ltGuillaume
on 16 Sep 2019
Hellp @ltGuillaume ,
Feel free to test the BETA version "Notepad3Portable_5.19.916.2636_BETA" or higher.
See "Notepad3 BETA-channel access #1129" or download it from Notepad3Portable_5.19.916.2636_BETA.
Further suggestions and comments are welcome... :smiley:
hpwamr
on 16 Sep 2019
Is this because of the
With 2636, _all_ keywords aren't hightlighted, _or_ they're incorrectly highlighted (e.g. Built-in Functions are highlighted as User-Defined Functions).
Maybe it has something to do with GitHub's web interface forcing a conversion to ANSI, instead of UTF-8? This was later addressed by @hpwamr, not sure if it made build 2636.
Otherwise, perhaps these special characters should be escaped somehow?
https://github.com/rizonesoft/Notepad3/pull/1639/files#diff-89eca6993a8c99afd36c672598d8b5d7R19
ltGuillaume
on 16 Sep 2019
Maybe it has something to do with GitHub's web interface forcing a conversion to ANSI, instead of UTF-8? This was later addressed by @hpwamr, not sure if it made build 2636.
Sure, the corrected encoding is Incorporated in Build 2636. 😮
hpwamr
on 16 Sep 2019
@ltGuillaume ,
I will try to correct the merged lexer.
Could you, please post a " test sample" file packed in .zip archive" ?
hpwamr
on 16 Sep 2019
ltGuillaume
on 16 Sep 2019
That is a Scintilla issue, cause Scintilla needs the word lists in lower-case 😨 🤔
Will check if a patch is possible ...
RaiKoHoff
on 16 Sep 2019
Could you, please post a " test sample" file packed in .zip archive" ?
windowspy.zip
Not an expert, but seems to work. I will compile a new Build.
hpwamr
on 16 Sep 2019
@ltGuillaume ,
Feel free to test the BETA version "Notepad3Portable_5.19.916.2637_BETA" or higher.
See "Notepad3 BETA-channel access #1129" or download it from Notepad3Portable_5.19.916.2637_BETA.
hpwamr
on 16 Sep 2019
Feel free to test dev beta ver _5.19.916.2639_BETA.
RaiKoHoff
on 16 Sep 2019
Fantastic! I'm humbled by the pace at which these issues are tackled! Great work @RaiKoHoff @hpwamr!
Now that I see the syntax highlighting in action, I understand why a few keywords were under Flow Control. I didn't think it made much sense (well, depends on how broad you define flow control) and thus I put them in the category in accordance with the keyword .txt files, but I understand the practical considerations now and created a pull request to put them back to flow control.
ltGuillaume
on 17 Sep 2019
One more fix for which I'm quite ashamed (props to @hpwamr, who apparently _is_ a petting zoo 😍, for his double-check) and this can be closed. Thanks for the extremely quick help, guys! 😎 See PR https://github.com/rizonesoft/Notepad3/pull/1645
ltGuillaume
on 17 Sep 2019
Remark: The Auto Completion ensures that the displayed list is ordered by a sort algorithm, also the internal Syntax-Highlighter (Lexer) needs an ordered list (and ensures this internally).
Both functionalities will have a better performance, if the provided keyword lists are already sorted.
(Lexicographical Order:
ASCII Table: (A-Z < a-z)).
RaiKoHoff
on 17 Sep 2019
needs an ordered list
If it's not too late, I'll do it this afternoon. 🤔
hpwamr
on 17 Sep 2019
Both functionalities will have a better performance, if the provided keyword lists are already sorted.
Sort in Lexicographic Order done. 😉
@ltGuillaume , As far as I am concerned, this issue may be closed....
hpwamr
on 17 Sep 2019
Yes, it works great now! Thank you both for all the work you put in, this is brilliant 😎👍
ltGuillaume
on 18 Sep 2019
Yes, it works great now! Thank you both for all the work you put in, this is brilliant 😎👍
Hello @ltGuillaume ,
You've opened this issue, so its owner is responsible for closing it... 😉 😃
hpwamr
on 18 Sep 2019
Haha, I guess that's true 😉👍
ltGuillaume
on 18 Sep 2019
Related issues
hpwamr
·
4Comments
craigo-
·
4Comments
hpwamr
·
3Comments
vvyoko
·
3Comments
hpwamr
·
3Comments
Most helpful comment
Fantastic! I'm humbled by the pace at which these issues are tackled! Great work @RaiKoHoff @hpwamr!
Now that I see the syntax highlighting in action, I understand why a few keywords were under Flow Control. I didn't think it made much sense (well, depends on how broad you define flow control) and thus I put them in the category in accordance with the keyword .txt files, but I understand the practical considerations now and created a pull request to put them back to flow control.