Notepad3: Vertical selection bug - Inconsistent selection while typing

[omega32]

While typing, the vertical selection changes. I didn't take the time to check when was this bug introduced, but it's present in the latest commit.

To reproduce:

1. Open the attached file or any file with sufficient text, so you can make a vertical selection (ex: 10 lines) (vertical-selection-bug.txt).
2. Make a vertical selection and start pressing "space" and "backspace" as you wish. The selection will start changing with no discernible pattern.

For example:
In this file, I selected just before all numbers and started typing. After pressing "space", "space", "space", "backspace", "space", "space" this is what I got:

I'm attaching my Notepad3.ini (Notepad3.zip) just in case.

[RaiKoHoff]

@omega32 : Hello omega32, welcome to Notepad3 @ GitHub.
Please tell the Notepad3 version you are using - with current development beta version, I am not able to reproduce this issue (maybe it is solved already).

[omega32]

Hello. I compiled the latest commit and the bug is there for me (commit a03bb04dfe5fdfd0f16e2471730c5cd32f0243a9). The vertical selection jumps all over the place while pressing space and backspace. It's not consistent though.

Notepad3 (64-bit) TinyExpr v4.18.912.1098
Scintilla v411 (RegEx: Onigmo v6.1.3)
Compiler: MS Visual C++ 2017 v15.8.4 (VC v1915)
(en-US) English(amer.) text by Flo Balmer et al.

I could start testing old versions until I get to one without this problem.

[RaiKoHoff]

OK, using your Notepad3.ini file, I am able to reproduce this bug. A pristine Notepad3 (no Notepad3.ini -> default settings) didn't show this bug :thinking: . I have to debug the issue ...

Ed.: It seems, that the bug has been introduced between dev-ß _803_1038 and dev-ß_803_1039,
but from the source-code changes, I am not able to see, what causes that issue :thinking: , need to dig deeper... (8th of August between 04:30h and 15:00h)

[RaiKoHoff]

Please test development beta _TinyExpr_4.18.917.1106.
(The issue has been solved by removing (obsolete) calls to SCI_MARKERDEFINE (bookmarks) while updating margin width on changes. So the problem is deep in Scintilla component. Since the calls were obsolete, I am not digging deeper here...

[omega32]

Seems to work perfectly now :+1:

[hpwamr]

As far as I am concerned, this issue may be closed....