Nodejs.dev: docs page: console warning: Encountered two children with the same key

Created on 4 Oct 2020  路  8Comments  路  Source: nodejs/nodejs.dev

Steps to reproduce

Navigate to /docs and select any topic then switch to another topic
For example select http then select http2

Expected result

No errors or warnings

Actual result

See screenshot

Screen Shot 2020-10-03 at 10 18 21 PM

  • OS Version: macOS
  • Browser Version: Chrome
bug hacktoberfest

Most helpful comment

The commit messages in this repo are not super strict.
I would do something like fix(docs.tsx) Thing I fixed
Personally I use a global npm package called commitizen npm install -g commitizen
My workflow looks like this

git add filename
git cz
select the option from the cli

All 8 comments

Hi @benhalverson I think it's an issue where we might be assigning keys based on some dynamic value but for some reason, that value is same for a hierarchy. Is it ok if I look into this issue and update here? Let me know.

Thanks!

Yep feel free to create a PR with a fix.

Awesome, thanks!

Hi @benhalverson

I was trying to make a commit following the commit guidelines and was trying to figure out the affected subsystem. I ran the command suggested but it provided me a list of some commit messages with multiple subsystems like fix and refactor. Can you please guide me on how can I create the commit message? Is there a way or provision to add multiple subsystems? PFA for the list of messages:
image

Thanks a ton!

Hey @Bhavin789, I'm not @benhalverson but I can help too 馃槃

In your case, when you're fixing a warning, most likely the perfect choice would be using fix subsystem.
For example, your commit message could like this:
fix: Prevent warnings related to duplicate keys in the docs page.

Additionally, take a look into our contribution guidelines. Also, conventional commits page is worth reading to further understand commit conventions.

The commit messages in this repo are not super strict.
I would do something like fix(docs.tsx) Thing I fixed
Personally I use a global npm package called commitizen npm install -g commitizen
My workflow looks like this

git add filename
git cz
select the option from the cli

Thanks a lot for the info @sbielenica , had the same thought but just wanted to be sure before for committing :smile: This helped, thanks again!

Thanks @benhalverson for sharing this :smiley: . This package looks super cool, heard for the first time :sweat_smile: . Will definitely try this out and update here.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

antsmartian picture antsmartian  路  3Comments

BeniCheni picture BeniCheni  路  4Comments

giankotarola picture giankotarola  路  4Comments

marcustisater picture marcustisater  路  3Comments

lidoravitan picture lidoravitan  路  4Comments