Nodejs.dev: There is extra space between 'Documentation' and 'Download' in nav bar on desktop

Created on 11 Aug 2020  路  5Comments  路  Source: nodejs/nodejs.dev

Description

There is more space between 'Documentation' and 'Download' than between 'Learn' and 'Documentation'. Should they be evenly spaced?

Screenshot of nav bar from staging branch.

Steps to reproduce

Check out the 'staging' branch locally, run with npm run, and visit the homepage at localhost:8000.

Expected result

The nav items should be evenly spaced. They are evenly spaced in the 'master' branch (screenshot below).

Screenshot of expected behavior from master branch.

Actual result

There is more space between 'Documentation' and 'Download' than between 'Learn' and 'Documentation'.

Screenshot of nav bar from staging branch.

Environment

  • OS Version: macOS 10.15.5
  • Browser Version: Google Chrome 84.0.4147.105
bug

Most helpful comment

The staging branch is no longer updated. Do you see this issue in the master branch or on nodejs.dev?

@benhalverson Ah, that would do it! In the Contributing Guidelines, it still says to work from the staging branch. I only see the issue on staging.

@itsjzt @marcustisater If it's true that I should be looking at master and not staging, then I don't see the issue either. :)

All 5 comments

I think this is only the case with desktops, I couldn't reproduce the issue on Laptop

image

The staging branch is no longer updated. Do you see this issue in the master branch or on nodejs.dev?

Sorry! I can't reproduce the same issue of your screenshot.

However I did find some tiny other fixes in the header that you can find in my PR.

Maybe you can check again @rmleg? 馃槂

The staging branch is no longer updated. Do you see this issue in the master branch or on nodejs.dev?

@benhalverson Ah, that would do it! In the Contributing Guidelines, it still says to work from the staging branch. I only see the issue on staging.

@itsjzt @marcustisater If it's true that I should be looking at master and not staging, then I don't see the issue either. :)

Great!

Then I think we can close this issue.

Thanks for checking again @rmleg

Was this page helpful?
0 / 5 - 0 ratings

Related issues

marcustisater picture marcustisater  路  3Comments

mhdawson picture mhdawson  路  4Comments

LaRuaNa picture LaRuaNa  路  4Comments

BeniCheni picture BeniCheni  路  4Comments

designMoreWeb picture designMoreWeb  路  3Comments