Nodejs.dev: site triggers a popup asking me to add to my homescreen

[devsnek]

pretty annoying popup by itself, but i especially don't think it makes sense on this site.

[ahmadawais]

@devsnek can you test the link in the build at #110

[MylesBorins]

@devsnek this is a feature of the fact the site is a progressive web app. Are you seeing this on desktop? it should only be showing up on mobile. If installed the site will be able to work offline.

[LaRuaNa]

@MylesBorins I think devsnek means mobile. It wouldn't pop up on desktop o_O. I agree at that point with @devsnek that's not really a feature we need. Since we have the gatsby-plugin-offline the page works offline without adding it to home screen from the worker.

[pierreneter]

I think we can't turn off this popup, this popup is generated by mobile browsers automatically if the site is available offline (pass PWA), as here by gatsby-plugin-offline.

[devsnek]

@ahmadawais i opened that build and looked around it for a few min and didn't see any popups, but the original popup didn't show immediately so i'm not sure if i just haven't seen it yet or if its actually gone.

[ahmadawais]

I think it's a standard feature for PWA's and we should just let it be. PWA's are fun and having site installed on someone's mobile won't make for a bad experience. I know many sites that do the same thing. Dev.to being a good example.

In any case, here are more details about the kind of options we have for this.

https://developers.google.com/web/fundamentals/web-app-manifest/#display

On my sites, I prefer to keep it to the 'minimal-ui' setting.

[devsnek]

I guess its just sort of an opinion thing. dev.to makes sense since its a platform, but sites like nodejs.dev which are just informational asking to install themselves on my phone makes me not want to not go to those sites anymore.

[MylesBorins]

@devsnek if you visit https://storage.googleapis.com/staging.nodejs.dev/7ca8359/index.html you should no longer see the prompt.

You will need to refresh your cache to get prompted again on main site (it will only prompt once).

[devsnek]

@MylesBorins said above, i haven't seen it 👍

[ahmadawais]

@devsnek It shouldn't show up now.

In order to show the Add to Home Screen Prompt, display must be set to standalone.

Right now it's set to browser for a standard browser experience.

I think this means we can close this now. 👍