Nodejs.dev: Scroll to active item on menu open

Created on 16 Feb 2019  路  8Comments  路  Source: nodejs/nodejs.dev

In both mobile and tablet views, when the side menu is opened, the menu scroll position should be set to show the selected page.

bug good first issue help wanted
Source
picture amiller-gh

Most helpful comment

I would be interested in working on this issue!

It's yours @kevjin :]

picture LaRuaNa on 21 Mar 2019
😄1 👍1

All 8 comments

Hi @amiller-gh,

I'm trying to recreate the issue but I think it is working as expected. Please can you verify and let me know if it's fixed or I'm looking at something wrong.

If the issuue still exists, I'll be happy to take it up. :)

KirankumarAmbati picture KirankumarAmbati on 20 Feb 2019

@KirankumarAmbati The content inside the menu should also be scrolled to top (when we go back to open menu again).

mbj36 picture mbj36 on 21 Feb 2019

Hello, tried out a fix for this issue in #123. Looking forward to the review.

BeniCheni picture BeniCheni on 24 Feb 2019
❤1

Friendly note that I closed #123 as I was having side effects, and I wasn't satisfied my workaround. This issue is open for any volunteer.

BeniCheni picture BeniCheni on 3 Mar 2019
👍2

I would be interested in working on this issue!

kevjin picture kevjin on 21 Mar 2019
❤2

I would be interested in working on this issue!

It's yours @kevjin :]

LaRuaNa picture LaRuaNa on 21 Mar 2019
😄1 👍1

Created a PR for a fix here: #203. Thanks!

kevjin picture kevjin on 24 Mar 2019

Implemented in https://github.com/nodejs/nodejs.dev/pull/203.

sagirk picture sagirk on 27 Mar 2019
Was this page helpful?
0 / 5 - 0 ratings

Related issues

benhalverson picture benhalverson  路  4Comments
mmarchini picture mmarchini  路  4Comments
BeniCheni picture BeniCheni  路  3Comments
lidoravitan picture lidoravitan  路  4Comments
benhalverson picture benhalverson  路  3Comments