Nodebb: Feature Request: Two-click (or as close as) to add user to StopForumSpam

[pauljherring]

To simplify adding users to StopForumSpam, since currently it involves copy/pasting three times between at least 2 (3 if the user is already registered) web pages...

https://www.stopforumspam.com/usage > Adding to the Database for details of SFS's API.

Admin/Moderator profiles would require an extra field into which the API Key (generated at https://www.stopforumspam.com/keys) would need to be stored. If this field is empty they attempted usage of the reporting buttons/functions below would generate an error indicating it needs to be filled out.

Anyone without privileges to view another user's IP address and email would not have this entry visible, nor would the reporting features be visible.

A report button would, at a minimum I suggest, be required on

• Registration Queue (/admin/manage/registration)
  

• User page (/user/$USERNAME)
  

Clicking those would take user to a new page listing the three known items about the user that will be reported (username, email, IP address) and would have an extra field for any evidence, and that page would submit to SFS.

[pitaj]

Perhaps this is better handled by the spambegone plugin? It deserves some pretty significantly improvements, at the moment SFS isn't even used by it I think.

[pauljherring]

I thought the underlying data retrieved from SFS for the registration queue was in core?

[pauljherring]

@barisusakli - thoughts? :)

[barisusakli]

stopforumspam is definitely used when displaying users in the registration queue.

[pauljherring]

I meant, would that be a better place for this request? :D

Edit: probably yes, if that's what's providing data into the reg. queue...

[barisusakli]

The stomforumspam code is in core actually https://github.com/NodeBB/NodeBB/blob/master/src/user/approval.js#L238

[julianlam]

We've reached out to @akhoury directly to discuss moving all this into spam-be-gone :smile:

[akhoury]

So i started working on this but i could use a little bit of guidance @julianlam

• Since stopforumspam was being used by nodebb core by default, I think it should be enabled by default in spam-be-gone, but

  • What happens when someone hasn't installed spam-be-gone? how should the Registration Queue page handle this? since right now, it relies on the result object spamData and ipMatch in the template
  • Do plugins have an "upgrade" process, if i were to enable this by default, I need to "update" this plugin's stored config object under Meta.settings
    

• I have no idea how to, __from the spam-be-gone plugin load callback__, add the "Report to StopForumSpam" buttons, one in the Registration Queue, and the other on the user's profile, just like the last 2 screenshots that @pauljherring shared
  
  

if that's in fact what we want to do, I really shouldn't be updating the core templates for this, no?

[pauljherring]

if that's in fact what we want to do

Those were only suggestions as to how I'd think it could work from an end-user point of view - they're not set in stone :)

[pauljherring]

What happens when someone hasn't installed spam-be-gone? how should the Registration Queue page handle this?

I'd go with don't show anything (extra) - same as if:

Anyone without privileges to view another user's IP address and email would not have this entry visible, nor would the reporting features be visible.

[akhoury]

also related commit https://github.com/akhoury/nodebb-plugin-spam-be-gone/commit/8001ab16db8c69bba74da903bae17629c55fe952

[akhoury]

Ok, so this is 99% ready, I just have to actually test the final request "reporting a spam to stopforumspam", i tried to register so i can get an API key, but they didn't send me the initial email, i just contacted their administrator.

As of now, ONLY administrators and Global Moderators can actually report someone as spam.

If StopForumSpam is enabled and API key exists

The error in red is because i used a fake key

If StopForumSpam is enabled but no API key

If StopForumSpam is disabled or spam-be-gone not activated

[akhoury]

related commits:
https://github.com/akhoury/nodebb-plugin-spam-be-gone/commit/d16f13c0900d71d823977f573a1c59263c353992 & https://github.com/akhoury/nodebb-plugin-spam-be-gone/commit/69145267d9172ddff83336d15dc39422a406a001

[akhoury]

pending https://github.com/NodeBB/NodeBB/pull/7284