Nodebb: Group Level privilege breaks on renaming

[darKnight0037]

• NodeBB version: v1.13.x
• NodeBB git hash: f879c4a84e137413f0bdd099e020ec0658124658
  

• Installed NodeBB Plugins:
  
  * nodebb-plugin-composer-default (installed, enabled)
  * nodebb-plugin-dbsearch (installed, disabled)
  * nodebb-plugin-emoji (installed, enabled)
  * nodebb-plugin-emoji-android (installed, enabled)
  * nodebb-plugin-markdown (installed, enabled)
  * nodebb-plugin-mentions (installed, enabled)
  * nodebb-plugin-soundpack-default (installed, enabled)
  * nodebb-plugin-spam-be-gone (installed, disabled)
  * nodebb-plugin-write-api (installed, enabled)
  * nodebb-rewards-essentials (installed, enabled)
  * nodebb-theme-lavender (installed, disabled)
  * nodebb-theme-persona (installed, enabled)
  * nodebb-theme-slick (installed, disabled)
  * nodebb-theme-vanilla (installed, disabled)
  * nodebb-widget-essentials (installed, enabled)

• Database type: mongo

• Database version: 4.2.3
  
• Exact steps to cause this issue:
  
  
  
  1. I created a group(G) and added member(A) to it.
  
  
  2. I assigned the privilege to that group for accessing topics in a category(C)
  
  
  3. I was able to access that topic after signing from member(A).
  
  
  4. Then I renamed group(G) to group(H).
  
  
  5. Now, when I try to access topics from group(H), I was shown access denied.
  
  
  6. Then I renamed group(H) to previous group(G).
  
  
  7. Then I was able to access the topics from the member(A).
  
  
• What you expected:
  I expected to be able to access topics from group(H).
  
• What happened instead:
  I was denied access to topics from the category(C)
  

[julianlam]

Thanks for reporting this issue. Looks like another bug due to the lack of group id's...

[barisusakli]

Seems like a cache issue, does it work after you restart nodebb after you change the group name?

[darKnight0037]

Seems like a cache issue, does it work after you restart nodebb after you change the group name?

It does work fine after restart. But it is not practical to restart our forum every time after renaming.
Thanks for fixing it.

[barisusakli]

I fixed it in the above commit so it will work without restarts.