Right now there are 2 upload icons and this is confusing.
The question is, which one is for images and which one is for files?
- Why does it have to be different?
- Assuming a good reason for 1, the current image logo is confusing. I realize #4453 changed it but the new one is more confusing. Not sure the best way to differentiate.
djensen47
All 5 comments
Open to swapping the icons to one that fit better for the action intended.
There seems to be a file-upload icon we can use now, and file-image could work for images.
julianlam
on 6 Apr 2019
Yeah, that looks good!
djensen47
on 12 Apr 2019
Sweetness.
On Fri, 12 Apr 2019, 01:08 Dave Jensen, notifications@github.com wrote:
Yeah, that looks good!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/NodeBB/NodeBB/issues/7427#issuecomment-482439094, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA4Vgxk5rL2KNhi-l0pzgh8QxSPTN0PWks5vgBTNgaJpZM4bbOqF
.
julianlam
on 12 Apr 2019
Okay, so I couldn't actually use those icons, as we don't use FontAwesome 5, but I did approximate them with the FA4 icons and a little hacking:
julianlam
on 17 May 2019
v6.2.13
julianlam
on 17 May 2019
Related issues
FaizanZahid
·
4Comments
tom-rade
·
3Comments
antoine-pous
·
3Comments
jidanni
·
5Comments
uplift
·
3Comments
Most helpful comment
Open to swapping the icons to one that fit better for the action intended.
There seems to be a
file-uploadicon we can use now, andfile-imagecould work for images.