Nodebb: User profile -> ban user has confusing and wrong instructions

[BenLubar]

https://github.com/boomzillawtf/tdwtf/tree/4866fca68b869575725e29627b5768ea868aa7fc
3df7bae08cea1dbb848500c4a4affb8533541743

Attempt to permanently ban a user from their profile page.

Instead of a permanent ban, this actually results in a ban that lasts 0 hours.

[julianlam]

Thanks, looks like a fairly pressing issue. In the meantime, might I suggest a 365 day ban?

[BenLubar]

Permanent bans from the admin panel work as expected.

[psychobunny]

I would just add a new button for permanent ban that calls the same method that the ACP does, instead of going for this 0 = permanent stuff

[julianlam]

It's probably a type issue, since both call the same websocket method.

[pauljherring]

In the meantime, might I suggest a 365 day ban?

Ah. We'll let you know how that works with Discourse in about 8 weeks...

[julianlam]

Oddly I couldn't reproduce on my end, but nevertheless, I've applied a fix, please let me know if it still does not work as expected.

[BenLubar]

The ban was done by a global mod.