Nextcloud-vue: User mention in comment field does not work for users with @ in name

Created on 3 Apr 2021  路  5Comments  路  Source: nextcloud/nextcloud-vue

First I thougt its solved with NC21. Selction works but we have users with special chars as "@" in their usernames. When I select one of those users the "@" inside the username is removed and so the user mention does not work

_Originally posted by @roadrunnerjb in https://github.com/nextcloud/server/issues/19523#issuecomment-810150432_

1. to develop bug rich-contenteditable

Most helpful comment

@ is allowed as a lot of people use email addresses alike syntax for the user id:
https://github.com/nextcloud/server/blob/master/lib/private/User/Manager.php#L413-L418

Registration app also has an option that forces the validated email as user id, so that has to be fixed here.

All 5 comments

cc @skjnldsv @nickvergessen

Oooh!
I was not even aware we allowed @ in uids :cry:
cc @rullzer @blizzz, isn't there a discussion about special chars i uids?

@ is allowed as a lot of people use email addresses alike syntax for the user id:
https://github.com/nextcloud/server/blob/master/lib/private/User/Manager.php#L413-L418

Registration app also has an option that forces the validated email as user id, so that has to be fixed here.

I guess this should move to the vue components?
As this is where the autocomplete takes place :)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

skjnldsv picture skjnldsv  路  9Comments

raimund-schluessler picture raimund-schluessler  路  3Comments

georgehrke picture georgehrke  路  9Comments

jancborchardt picture jancborchardt  路  9Comments

raimund-schluessler picture raimund-schluessler  路  9Comments