Nextcloud-vue: ActionLink looks odd inside Actions

[georgehrke]

ActionLink looks odd inside an Actions component:

[georgehrke]

Plus there is no ellipsis or line-break on long text

[skjnldsv]

There is an issue with the title :)
Can you post some code pls?

[georgehrke]

<Actions>
    <ActionButton icon="icon-add" @click="alert('Add')">Add new</ActionButton>
    <ActionButton icon="icon-delete" title="Long button" @click="alert('Delete')">This button is associated with a very long text.\nAnd with new lines too.</ActionButton>
    <ActionLink icon="icon-add" title="I'm a short title" />
    <ActionLink icon="icon-add" title="I'm a very long title that doesn't break for some reason" />
</Actions>

[skjnldsv]

https://github.com/nextcloud/nextcloud-vue/blob/d08ba3b8d00edb22c569b8dba50732b1b30c8d82/src/components/ActionLink/ActionLink.vue#L63

I guess we should only use the title/text combo when there is a title set?
Or we increase the min width? https://github.com/nextcloud/nextcloud-vue/blob/bb92adadae6409f4698b9b284733b72144c971f5/src/mixins/actionGlobal.js#L49

[georgehrke]

Oh, if i use <ActionLink icon="icon-add">I'm a short title</ActionLink> it shows normally. Why didn't you say that :P

[skjnldsv]

Why didn't you say that :P

...
Have you read the documentation? ^^'

[georgehrke]

Have you read the documentation? ^^'

Yes, i did :P

There is exactly one example and it uses title
https://nextcloud-vue-components.netlify.com/#/Components/Actions?id=actionlink

[skjnldsv]

Git blame is blaming :drum: :drum: :drum: :drum: @skjnldsv

God dammit!!!

[skjnldsv]

Fix https://github.com/nextcloud/nextcloud-vue/pull/682