Newpipe: Change timestamp behavior

Created on 6 Sep 2020 · 12Comments · Source: TeamNewPipe/NewPipe

Describe the feature you want

Timestamps should seek in the Unified Player instead of starting a pop-out player.

Is your feature request related to a problem? Please describe it

N/A

Additional context

N/A

How will you/everyone benefit from this feature?

Timestamp-based pop-out players are the inferior solution compared to instantly seeking in the unified player.

player

Source

snappyapple632

👍1

Most helpful comment

I didn't see this as unintended behavior, that's why I posted this as a feature request. I felt this suggestion was more relevant and doable now that the player is going to work more like YouTube's. I honestly don't see the reason why timestamps have to make additional instances of the player if we already have a system that works in-line with the user interface.

My suggestion for the comments issue would be to compress the player about half it's height to the upper edge to make more room for the comments.

snappyapple632 on 6 Sep 2020

👍3

All 12 comments

why bug @opusforlife2 @TobiGr?

B0pol on 6 Sep 2020

Unexpected behaviour compared to Youtube and Invidious?

opusforlife2 on 6 Sep 2020

That's how I differentiate between the two, anyway.

Bug: did something and got an unexpected result.
Feature request: wanted to do something and was unable to do so.

opusforlife2 on 6 Sep 2020

It is expected here. We did not change code about this therefore we do not expect the behavior to change.

B0pol on 6 Sep 2020

You're speaking from the perspective of a developer here. There is probably no bug in the code, sure. But from a user's perspective, there is a bug in the behaviour. No user would tap on a timestamp and expect to see a popup of the same video. And it's not documented anywhere in the app that that's something that will happen. Any user who's used this functionality in Youtube or Invidious _will_ expect to jump to that timestamp in the same video, though.

opusforlife2 on 6 Sep 2020

But then by definition it's a request, feature request

And even as a user. I don't see the difference before and after unified player as you still can't view comments without popup player.

I don't want to scroll up to see the video after clicking on a timestamp, scroll down again for comments, scroll up for another timestamp…

YouTube is completely different because the video continues to play while viewing comments, that's basically our popup mode.

Compare YouTube:

And NewPipe:

The only way to reproduce youtube behavior is popup player

That's why we are launching popup player on timestamp and that's also why it shouldn't change

And please don't mention YouTube's desktop behavior, desktop ≠ mobile

B0pol on 6 Sep 2020

👍1

It's definitely not a bug with the unified player, but existing behaviour from the past, so that should be removed from the title, I agree.

opusforlife2 on 6 Sep 2020

YouTube is completely different because the video continues to play while viewing comments, that's basically our popup mode.

Ah yes. I think avently was testing this out at some point, but it wasn't implemented. I forgot why.

I don't want to scroll up to see the video after clicking on a timestamp, scroll down again for comments, scroll up for another timestamp…
YouTube is completely different because the video continues to play while viewing comments, that's basically our popup mode.

Would it not be possible to have the app 'jump' to the top upon tapping a timestamp?

I don't see why someone would tap several timestamps in a row, anyway. That seems like a corner case.

opusforlife2 on 6 Sep 2020

Also, how does this possibility sound? : If the video is paused, then it should scroll up just like it currently does, letting comments or suggested videos fill up the screen. But if the video is playing, then comments and videos should scroll under it.

opusforlife2 on 6 Sep 2020

My suggestion for the comments issue would be to compress the player about half it's height to the upper edge to make more room for the comments.

snappyapple632 on 6 Sep 2020

👍3

@opusforlife2 let's see from a developer perspective.
When you see that something you make has a label "bug" you think that you made something wrong and it's not make you happy. When you see a "feature request" it means that something new could be added and it's flne.

For you it may may sounds the same but because you don't write a code. It's like saying "a bug" when I disagree with your point in a comment:)