Neos-ui: Keyboard shortcut-Feature issue with inline editable fields

Created on 18 Jul 2018 · 14Comments · Source: neos/neos-ui

Description

Sometimes shortcuts are also triggered when focusing an inline editable field.

Steps to Reproduce (not always)

create new page
set focus on the inline editable headline
press shortcut, e.g ti

Expected behavior

No shortcut triggering

Actual behavior

All toggle shortcuts could be triggered

Affected Versions

Neos: 3.3.12
UI: 1.1.2

Bug

Source

KPeschke

Most helpful comment

Yep, no one came up with a good solution by now, except modifier keys but someone said we should first check how other web apps are doing it and that was it until now

mstruebing on 23 Aug 2018

👍2

All 14 comments

This shouldn't happen ofc, but there may be are some timing issues - we are thinking about introducing a modifier key or something but aren't sure at this point

mstruebing on 18 Jul 2018

This issue is really annoying, just got some bug reports from our customers. Will deactivate the shortcuts for now.

DrillSergeant on 8 Aug 2018

Does it still happen with the latest release?

dimaip on 22 Aug 2018

Nope, but you can disable them since some time

mstruebing on 22 Aug 2018

@mstruebing so this issue is no longer relevant and can be closed?

dimaip on 22 Aug 2018

The issue is still there - if you have them activated(currently default) you will get this buggy behaviour.
But if this issue annoys you you have the possibility to deactivate them.

To do that set Neos.Neos.Ui.frontendConfiguration.hotkeys to empty (~) or empty array ([])

mstruebing on 22 Aug 2018

👍1

Ah, I see, then we should find a reliable way to reproduce it and fix it

dimaip on 23 Aug 2018

Yep, no one came up with a good solution by now, except modifier keys but someone said we should first check how other web apps are doing it and that was it until now

mstruebing on 23 Aug 2018

👍2

Can confirm, have this issue as well.

kitsunet on 24 Aug 2018

I can confirm too. Did we have a place in the state where we can store "currentlyEditing" when focusing on input and inline. And then the shortcut module can take decision based on this value ?

dfeyer on 2 Oct 2018

@dfeyer Yes, we do.

dimaip on 2 Oct 2018

@dfeyer Yes, we do.

But it doesn't work in this case ?

dfeyer on 2 Oct 2018

No idea, I never looked into how the feature is currently implemented (@mstruebing might know more), nor was I able to reproduce the bug on my machine.

dimaip on 2 Oct 2018

This is the current implementation: https://github.com/neos/neos-ui/blob/9fa571adba1fb5631e5398886932634a1d043bc1/packages/neos-ui/src/Sagas/UI/Hotkeys/index.js#L39

I might have some time soonish to try another approach

mstruebing on 2 Oct 2018

Was this page helpful?

0 / 5 - 0 ratings