Mini-graph-card: Contribute upstream?

Created on 3 Oct 2018  路  4Comments  路  Source: kalkih/mini-graph-card

Really love this card. It's awesome.

Would you want to contribute it back to official repo at https://github.com/home-assistant/home-assistant-polymer ?

Most helpful comment

Hit me up on Discord if you get stuck and I'll help.

All 4 comments

@balIoob
I would love to!
However it's a LitElement atm, and the overall quality of the code is not really on par with the official repo, but I guess that could be worked on.

Do you want me to create a PR when I've refactored the code into the official repo?

I have been following the Lit Element work closely and have been planning to adopt it. They recently changed their API and are assuming is going to be stable, so I am fine with adding Lit Element to our repo. I hope that eventually most of our repo can be converted to Lit 馃槑.

Code can be cleaned up while it's in the repo too. I think that there are some functions that can be replaced with existing helpers but generally I think this code is good to go.

Hit me up on Discord if you get stuck and I'll help.

Closing this as the base of the card was contributed to Home Assistant as the sensor card.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

tomlut picture tomlut  路  4Comments

xstrex picture xstrex  路  7Comments

QkulleQ picture QkulleQ  路  7Comments

yadenisenko picture yadenisenko  路  4Comments

WhistleMaster picture WhistleMaster  路  3Comments