Mingw-packages: gstreamer-plugins-bad webrtcdsp plugin

[Ralayax]

Hello,

I realized that the webrtcdsp plugin wasn't being build on this repo.
If I am not mistaken, there was an issue on windows preventing this plugin to be built : https://gitlab.freedesktop.org/gstreamer/cerbero/-/issues/32

The issue on windows seems to have been fixed, and the plugin is included in gstreamer's latest official mingw build.

The upstream fix can be found here.
https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/30

Dwebrtcdsp=disabled should maybe be removed now that upstream is fixed.

Cheers,
Ralayax

[Biswa96]

You can create a pull request for this change. Contributions are always welcomed! 🤗

[Ralayax]

Yep I'm on it. I'm just gonna check that the build actually works before trying to pull random changes onto your project.

[Biswa96]

This requires a webrtc-audio-processing package. But there are some compiler error. I am in discussion with upstream developers.

[Ralayax]

Absolutely, sorry for the lack of follow up.
A webrtc-audio-processing package would also require Google's Abseil library.

The main compiler error is the usage of msvc's __try and __except which aren't supported in mingw if I'm not mistaken.

[Biswa96]

A webrtc-audio-processing package would also require Google's Abseil library.

I have already done that but it also has some quirks. Abseil is also compiled in mingw-w64-grpc package, so only half was already done.

The main compiler error is the usage of msvc's __try and __except which aren't supported in mingw if I'm not mistaken.

It is in SetThreadName function which is not so important, so can be enclosed within #ifdef _MSC_VER i.e. MSVC only.

[Ralayax]

Yes, I'm just afraid of rare and hard to fix glitches if we just remove those.
I found a guy that implemented a full MinGW version of the SetThreadName :
https://gist.github.com/rossy/7faf0ab90a54d6b5a46f

[mingwandroid]

Nice find! This would enable us to build chromium worth it's sandbox stuff poasibly?