Metrics-server: Revise prometheus metrics

Created on 25 Feb 2020  路  9Comments  路  Source: kubernetes-sigs/metrics-server

As suggested by @s-urbaniak in https://github.com/kubernetes-sigs/metrics-server/pull/387
We should leverage the best practices we defined in https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/20181106-kubernetes-metrics-overhaul.md#motivation and start dependency injecting the prometheus registry into components.


/kind feature

help wanted kinfeature prioritimportant-longterm

Most helpful comment

Sounds interesting, I can give it a try :)

All 9 comments

/help

@serathius:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

/remove-lifecycle stale

@s-urbaniak
Having quality metrics is very important for next release. I added this issue to v0.4.0 milestone, that I will be preparing to release in near feature.
Will you be able to work on this?

@serathius yeah, i'll give it a spin! :tada:

We have precendences in the eco-system on how to dependency-inject registries in kubelet [1]. I will work towards that idiom.

[1] https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/server/server.go#L389-L394

cc @dgrisonnet how do you feel of tackling this one? :-)

Sounds interesting, I can give it a try :)

Was this page helpful?
0 / 5 - 0 ratings