Meshcentral: [xterm.js 0.4.7-s] scaling problem

[GusevVictor]

Step to reproduce:

• use Windows as client (firefox ESR 68)
• upgrade to v 0.4.7-s
• connect to any linux host by xterm.js
• just see screens

THE GOOD NEWS: MC WORKS in xterm.js. YES! YES YES

[TotallyNotElite]

Do you mind explaining how you got to that screen? I'll try fixing the issue if I can find out how to get there..

[GusevVictor]

Do you mind explaining how you got to that screen? I'll try fixing the issue if I can find out how to get there..

Just open and noting else. Please see screens:

I have type mc command (for example):

See the result

I didn't resize a browser window.

p.s. sorry for russian lang screens.

[TotallyNotElite]

Yes I see the problem. MC doesn't send stty resize commands to set the amount of rows and columns. I'm not sure how one would go about dynamically resizing the terminal without spamming the terminal with stty commands.

[GusevVictor]

There is not only mc problem, also top, htop

WOW bash eats 100% CPU... Hm... Very strange.

[GusevVictor]

Wow...

[TotallyNotElite]

I have a fix, I'll implement it when I have time (20 minutes maybe?)

[TotallyNotElite]

Ok I was going to implement this:
https://github.com/copy/v86/issues/172#issuecomment-397017560

But this significantly slows down running of commands. My second thought is making the agent send a signal to the terminal client.

[GusevVictor]

Wow..! How I can to test it? I need just wite for a new release of mesh? :)

[Ylianst]

I know about this problem, I just started working with XTerm yesterday morning and released it in the afternoon, so not everything is well yet. I was going to fix this by sending a signal to the terminal (not by using stty), it will take a while to fix.

[TotallyNotElite]

@Ylianst that was how I was going to do it, I can do that for you if you want. How would you like me to send the data/identifier to send the signal? Just send it over the existing connection?

[Ylianst]

Just published MeshCentral v0.4.7-t that will now set the right terminal size at the start and send the resize events to the agent. Bryan is working on getting the agent to resize the terminal now, you can search for 'termsize' in meshcore.js for the "TODO" lines.

We have an agreement that when sending data on the websockets, "binary" type is data and "string" data type is control. So we can easily multiplex the terminal and control data.

[TotallyNotElite]

@Ylianst Well dammit I'm basically done doing this myself...

[Ylianst]

If you have code for the 'termsize' in meshcore.js for the "TODO" lines, we would like that. Bryan and I are stumped as to how to reside the terminal once it's running.