Mentorship-android: Write Espresso Test for "Change Password" (a)

[iofall]

Write an Espresso test for the “Change Password” dialog feature (a) (Scenario: ”Check whether errors are shown when the password is weak”)

Describe the solution you'd like
Espresso tests to cover the Change Password feature of the app, on the Settings screen, when the password is weak.

The tests will go here

Acceptance criteria:

• [ ] Connect Android device or open the emulator
• [ ] On terminal type ./gradlew clean build connectedAndroidTest --stacktrace
• [ ] Wait for your test to complete
• [ ] See the complete report ../mentorship-android/app/build/reports/androidTests/connected/index.html and check if this test passed.

[justdvnsh]

Hi @iofall @aditmehta9 . I would love to work on this issue. Can I take up this issue as a participant of OSH ? I would also love to take Issue #804 with , since both the tests would be made in one single file. Can you please assign me these issues ?

[aditmehta9]

Hi @iofall @aditmehta9 . I would love to work on this issue. Can I take up this issue as a participant of OSH ? I would also love to take Issue #804 with , since both the tests would be made in one single file. Can you please assign me these issues ?

I am not sure please ask @vj-codes or @iofall or @sakshi1499 because you are assigned other issue.

[vj-codes]

@justdvnsh hey , please work on one issue at a time . Although the changes are made in same file , it's difficult for reviewers later to review and approve PRs with huge changes.
You are already assigned #792 , after you complete that one , you can work on this.
And for #804 , just comment that you're interested and would like work after current issue is done:)

[justdvnsh]

@vj-codes Sure.

[vj-codes]

@justdvnsh since you've created a PR for #792 , would you like to work on this?

[justdvnsh]

@vj-codes That's why I commented on this issue 😅. But then I thought, I can work when my current PR gets accepted. Yes for sure. Please assign me this issue. I'd love to work on this issue.

[vj-codes]

@justdvnsh I saw your PR after commenting here.Otherwise would have assigned earlier:)

[justdvnsh]

@vj-codes No Problem. Thank You !

[justdvnsh]

Hi. @iofall @vj-codes. I have create the PR. But I am facing one issue. I created another branch for this issue since my previous commits is yet to be reviewed. Thus, I tracked only the latest file. But in the commit my previous commits have also been added File which was made in my previous commit. Can you please help me out on this ?

[iofall]

Hi. @iofall @vj-codes. I have create the PR. But I am facing one issue. I created another branch for this issue since my previous commits is yet to be reviewed. Thus, I tracked only the latest file. But in the commit my previous commits have also been added File which was made in my previous commit. Can you please help me out on this?

@justdvnsh I am not sure what you mean. If I understand correctly - You made a branch for working on #803 and you created a PR from that branch. Now I think you accidentally added additional commits to this for working on #804 right?

[justdvnsh]

Yes You understood the problem correctly @iofall . Just that, I was assigned issue #792 before this . So I created a PR for it. Now while working for this issue (#803), I created another branch, from which I created a PR recently. But in that PR I can see commits which I made to solve issue #792.

[iofall]

Oh ok I see. For #792 you directly committed from the develop branch. So when you created a new branch using git checkout -b somename, it already had the commits you had previously created on the develop branch.

We can fix this checkout - https://stackoverflow.com/questions/1338728/delete-commits-from-a-branch-in-git#:~:text=git%20rebase%20%2Di%20HEAD~%3C,Voila! After dropping the commit, push the branch upstream so that the PR gets updated as well. You might have to force push it.

If you face any problems, feel free to ask on Zulip or here.

[iofall]

Or maybe the above solution could be a bit complex. You could also add a new commit which removes the file and then push it. This will probably be easier, since we squash all commits before merging.

[justdvnsh]

Thanks @iofall . I'll check that out and update you accordingly.

[iofall]

While you are at it, remember to follow the guidelines for making commit messages https://github.com/anitab-org/mentorship-android/wiki/Commit-Message-Style-Guide