Mentorship-android: Make PopUp Menu into a single Settings screen

Created on 16 Oct 2018  路  11Comments  路  Source: anitab-org/mentorship-android

Description

As a user,
I need to have all the settings in a screen,
so that I can have organized multiple settings instead of having a long pop up menu.

This is a question of User experience. Right Now there isn't anything specific thought for the Settings screen, so instead of having a settings option in the pop-up menu, we could have a screen dedicated to settings and the other options that the pop-up menu provides.

A single screen that contains the pop-up menu items, such as Feedback, Settings, Log out and About screen. This would be an Activity. Instead of having the 3 dots icon, we could have a wheel icon representing general settings.

We may need a simple screen UI design and only then start coding, or one contributor could be responsible for both tasks.

Additional context: This was discussed when preparing issues for GHC Open Source Day.

Mocks

_Whoever works on this can suggest a UI for this, and put an image on comments section_

Acceptance Criteria

Update [Required]

  • [ ] Replace tree dots icon for a settings icon
  • [ ] Open a new screen dedicated to "Settings", this will include an "About", "Feedback" (not implemented yet), "Delete Account", "Logout".
  • [ ] No need to implement the actual screen that comes from it, just the settings, the other screens can be made and linked in other PRs.

Definition of Done

  • [ ] All of the required items are completed.
  • [ ] Approval by 1 mentor.

Estimation

3 - 5 hours

Coding Enhancement

All 11 comments

I think that we could have a separate screen dedicated for settings. As u said we could have a wheel icon representing general settings.
I would like to work on this 馃槆

@mohak1283 Thank you for your interest, but this may need some more discussion. I just created the issue so I would not forget about this.

Okay @isabelcosta

@mohak1283 will let a newcomer take care of this issue and then the delete account can be open from here

Cool @isabelcosta :+1:

Sorry, I said a newcomer could take care of this, but on another hand, other issues are dependant on this, and since you wanted to work on the other... I suggested that you would work on this one. Do you still want to @mohak1283 ?

Okay, will work on this issue :+1: @isabelcosta

In this issue, I also need to add the delete account feature? @isabelcosta

Or I have to only create UI of SettingsActivity? @isabelcosta

@mohak1283 I think SettingActivity is enough. In this way, the PR will be focused on the new UI instead of the API integration as well.

Okay @isabelcosta :+1:

Was this page helpful?
0 / 5 - 0 ratings

Related issues

isabelcosta picture isabelcosta  路  4Comments

iofall picture iofall  路  7Comments

vaishnavi-29 picture vaishnavi-29  路  3Comments

Priyansh-Kedia picture Priyansh-Kedia  路  6Comments

devanshi7799 picture devanshi7799  路  8Comments