Mattermost-server: Highlight matched text in search results

Created on 30 Aug 2019  路  12Comments  路  Source: mattermost/mattermost-server

Should be done on the mobile repo: https://github.com/mattermost/mattermost-mobile

Search results should have matching text highlighted as it does in the web app. This includes highlighting matching words, quoted phrases, emojis, hashtags, at mentions, and wildcards (such as boat* matching boats and boating). A full list of things that should be highlighted is here: https://github.com/mattermost/mattermost-server/blob/master/tests/test-search.md

There'll likely be significant overlap between this ticket and the one to add mention highlighting to mobile (https://mattermost.atlassian.net/browse/MM-5957), but there are at least a couple major differences that may make this more complicated:

  1. This needs to support Elasticsearch and non-Elasticsearch results. Elasticsearch results include the exact strings matched by the server while we have to parse the search string for non-Elasticsearch to find matching parts of the text (including doing wildcard matching)
  2. On the web app, we support highlighting in multiline code blocks by using some tricky CSS. This may not be possible on mobile, although it would be good to try to add this still.

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-12247

AreEnd User Feature Medium Help Wanted TecReact Native

All 12 comments

This one seems interesting, can I take it? Thanks
@jespino @enahum Actually who should I be @ ing lol

@kdenz absolutely, go ahead

Hey @kdenz,

Do you have any questions about this ticket?

Hey @hanzei , sorry I was occupied previously, will aim to finish it within next few days, thanks!
Will let you know when I encounter any problems

Hey @kdenz, just touching base to see how things are going and if you have any questions so far?

Hey @kdenz any progress on this? will you continue working on this ticket?

Hey so sorry guys, I can finish it before february, is that okay? @enahum @jasonblais

Hi @kdenz, sure thing, let's aim by end of February :)

Hi @kdenz, have you had a chance to take a second look at this issue? If any questions, let us know!

@jasonblais Hey yes~ I'm working on a PR now! Sorry

Thanks @kdenz, looking forward to it! :tada:

@kdenz any progress on this one ?

Was this page helpful?
0 / 5 - 0 ratings