Mattermost-server: Accepting Pull Requests: Remove "Disable Files Storage" option from System Console > File Storage (Good First Contribution)

[okin]

I just did setup a mattermost instance and wanted to disable storing files in the System Console -> File Settings.
But upon selecting _Disable File Storage_ and then pressing _Save_ I got an error message:

Invalid driver name for file settings. Must be 'local' or 'amazons3'

[it33]

Thanks @okin, we're planning to remove the _Disable File Storage_ option as it was originally included as and alternative to S3, but since we added local storage as an option, it probably doesn't make sense to support this any more. Also, file storage is needed for Profile Pictures.

Ticket Accepting Pull Requests to remove _Disable File Storage_

Just curious, were you reporting the issue because you happened to notice it, or is there a scenario where disabling file storage was important to your deployment?

[okin]

Hello @it33,
I did neither know about the requirement for profile pictures nor the plans to remove this setting.
I'd be fine with removing this then as we do use profile pictures and plan on keeping them. ;)

My original plan was to disable storing of files on mattermost. We do have a central file storage and I did not want to have another place where people may need to look for files and that I'd need to backup.

[it33]

Closing since we have a Jira ticket for this

[digitalageexperts]

I'm looking to use Mattermost for my company mostly because Slack is blocked behind our clients firewall. It's blocked due to the file sharing aspect. I was hoping to be able to disable file sharing with mattermost, but it seems you've recently removed that option. Is it possible to reintroduce the option and just default it to enabled? Seems like it would be an easy win if it existed before.