Matterbridge: Slack leaves empty attachments visible on Android

[ninja-]

If you have a configuration problem, please first try to create a basic configuration following the instructions on the wiki before filing an issue.

Please answer the following questions.

Which version of matterbridge are you using?

run matterbridge -version
version: 1.2.1-dev

If you're having problems with mattermost please specify mattermost version.

Please describe the expected behavior.

There should be not empty attachments visible on Android Slack app.

Please describe the actual behavior.

For every text message forwarded to slack, empty attachment is visible on the Android app.
It's probably related to this piece of code

        np.Attachments = append(np.Attachments, slack.Attachment{CallbackID: "matterbridge"})
        np.Attachments = append(np.Attachments, b.createAttach(msg.Extra)...)

But I am not sure if removing it will break detecting "own" messages or something based on the CallbackID in attachment...

Use logs from running matterbridge -debug if possible.

Any steps to reproduce the behavior?

1. Setup mattermost->slack pipe
2. Post something on mattermost
3. Open slack on Android and see empty attachment next to the message

Please add your configuration file

(be sure to exclude or anonymize private data (tokens/passwords))

[42wim]

Also see https://github.com/42wim/matterbridge/issues/262#issuecomment-330369260
Yes, removing it will break detection.

[ninja-]

@42wim maybe we can request slack to "fix it" on mobile...after all it's not displayed on the web version, so there is some check that blocks display of empty attachments.

[42wim]

@ninja-: feel free to do that :)

[ninja-]

I sent a ticket with details, I'll let you know if they agree to fix it.

[ninja-]

Slack acknowledged this as a bug, it will be fixed but there's no date yet

[42wim]

Cool, is there a link somewhere I can refer to?

[ninja-]

sadly no but they will message me when the fix goes live, so I'll forward that information here

[ninja-]

[ninja-]

fixed upstream :)

[42wim]

cool! thanks for remembering :)

[ninja-]