Matterbridge: IRC not fully connecting on GameSurge

[pb30]

Describe the bug
Bot runs and connects to GameSurge, but never joins channel or runs RunCommands. Shows as online in /whois and messaging bot shows incoming messages in debug log, but seems like bot hasn't detected that it has connected. Replacing server with irc.freenode.net works as expected with same config/machine. Config and logs below.

Comparing to other networks, this debug line is never printed with GameSurge
[0006] INFO irc: Connection succeeded

Screenshots/debug logs

[0000]  INFO main:         Enabling debug
[0000]  INFO main:         Running version 1.12.4-dev e3cb665
[0000]  INFO main:         WARNING: THIS IS A DEVELOPMENT VERSION. Things may break.
[0000]  INFO gateway:      Parsing gateway general
[0000]  INFO gateway:      Starting bridge: irc.pb
[0000]  INFO irc:          Connecting irc.gamesurge.net:6667
[0000] DEBUG irc:          "CLIENT_INIT :irc.gamesurge.net:6667"
[0000] DEBUG irc:          "NOTICE AUTH :*** Looking up your hostname"
[0000] DEBUG irc:          "NOTICE AUTH :*** Checking Ident"
[0000] DEBUG irc:          "NOTICE AUTH :*** No ident response"
[0000] DEBUG irc:          "PING :2495451530"
[0000] DEBUG irc:          "NOTICE AUTH :*** Couldn't look up your hostname"
[0000] DEBUG irc:          ":Prothid.NY.US.GameSurge.net 001 pb-bridge :Welcome to the GameSurge IRC Network via NFOServers.com, pb-bridge"
[0000] DEBUG irc:          Registering callbacks
[0000] DEBUG irc:          "CLIENT_GENERAL_UPDATED"
[0000] DEBUG irc:          "CLIENT_GENERAL_UPDATED"
[0000] DEBUG irc:          "CLIENT_GENERAL_UPDATED"
[0000] DEBUG irc:          "CLIENT_GENERAL_UPDATED"
[0000] DEBUG irc:          ":Prothid.NY.US.GameSurge.net NOTICE pb-bridge :Highest connection count: 2 (1 clients)"
[0000] DEBUG irc:          ":Prothid.NY.US.GameSurge.net 422 pb-bridge :MOTD File is missing"
[0000] DEBUG irc:          ":Prothid.NY.US.GameSurge.net NOTICE pb-bridge :on 7 ca 3(400) ft 10(10) tr"
[0000] DEBUG irc:          ":pb-bridge!~pb-bridge@2600:3c03::f03c:91ff:fe26:434c MODE pb-bridge :+iw"
[0000] DEBUG irc:          ":[email protected] NOTICE pb-bridge :\x02------------- MESSAGE(S) OF THE DAY --------------\x02"
[0000] DEBUG irc:          ":[email protected] NOTICE pb-bridge :[\x02users\x02] Notice from ThiefMaster, posted 01:47 PM, 04/09/2015:"
[0000] DEBUG irc:          ":[email protected] NOTICE pb-bridge :We've just started cloaking the IPs of all users on connect. This should improve your privacy and also lower the risk of being targeted by packet kiddies."
[0000] DEBUG irc:          ":[email protected] NOTICE pb-bridge :[\x02users\x02] Notice from GameSurge, posted 08:59 PM, 05/11/2013:"
[0000] DEBUG irc:          ":[email protected] NOTICE pb-bridge :You can now follow GameSurge on Twitter bit.ly/1607zvW and Facebook on.fb.me/10Aq5Dx Please \"like\" and \"follow\" us to be kept up-to-date on network news, events, and other items!"
[0000] DEBUG irc:          ":[email protected] NOTICE pb-bridge :[\x02users\x02] Notice from feigling, posted 08:24 PM, 07/17/2008:"
[0000] DEBUG irc:          ":[email protected] NOTICE pb-bridge :GameSurge provides a new service called SpamServ which moderates your channel. If you are interested in learning more about it read http://www.gamesurge.net/cms/SpamServ"
[0000] DEBUG irc:          ":[email protected] NOTICE pb-bridge :[\x02users\x02] Notice from GameSurge, posted 12:27 PM, 01/20/2007:"
[0000] DEBUG irc:          ":[email protected] NOTICE pb-bridge :Please be familiar with the GameSurge Acceptable Use Policy. All users on the network are required to abide by it. http://www.gamesurge.net/aup/"
[0000] DEBUG irc:          ":[email protected] NOTICE pb-bridge :\x02---------- END OF MESSAGE(S) OF THE DAY ----------\x02"
[0000] DEBUG irc:          ":Prothid.NY.US.GameSurge.net 396 pb-bridge ~pb-bridge@137f0963:ceec70dd:e8110605:IP6 :is now your hidden host"
[0000] DEBUG irc:          ":pb-bridge!~pb-bridge@137f0963:ceec70dd:e8110605:IP6 MODE pb-bridge :+x"
[0000] DEBUG irc:          ":[email protected] PRIVMSG pb-bridge :\x01VERSION\x01"
[0002] DEBUG irc:          "CLIENT_CONNECTED :irc.gamesurge.net:6667"
[0060] DEBUG irc:          ":Prothid.NY.US.GameSurge.net PONG Prothid.NY.US.GameSurge.net :1548189344063030586"

Environment (please complete the following information):

• Debian 9.6
• Compiled nightly, 1.12.4-dev e3cb665

Additional context

[irc]
[irc.pb]
Server="irc.gamesurge.net:6667"
Nick="pb-bridge"
RunCommands=["PRIVMSG pb30 hello"]

[[gateway]]
name="general"
enable=true

    [[gateway.inout]]
    account = "irc.pb"
    channel="#pb-bridge"

[pb30]

Looks like it's because GameSurge sends MOTD over NOTICE, so ENDOFMOTD event never fires. Adding ERR_NOMOTD handler seems to resolve issues, but not sure if that's the best solution

        i.Handlers.Add(girc.RPL_WELCOME, b.handleNewConnection)
        i.Handlers.Add(girc.RPL_ENDOFMOTD, b.handleOtherAuth)
        i.Handlers.Add(girc.ERR_NOMOTD, b.handleOtherAuth)
        i.Handlers.Add(girc.ALL_EVENTS, b.handleOther)

[42wim]

Hey, thanks for reporting and fixing this! 👍
Your suggestion looks fine, it's because it's not sending any MOTD whatsoever, so the ERR_NOMOTD is ok to use here.

(available in master now)

[patcon]

Heyo! Long time no see wim :)

Small discussion point: it's often in my personal github reflexes that when someone suggests a very small and clear change, I try to attribute them through the --author git option. The github-email tool makes it pretty easy to find the proper value (i.e. "Phil B <[email protected]>").

I know most people aren't concerned enough to have a complaint with doing otherwise, but i'm hopeful the extra step comes across as thoughtful and generous, and people seem to appreciate it! Sometimes those small changes are the result of hours of work, so it feels nice to get the suggester into the contributor list :)

@42wim Might this be a convention that matterbridge project would be willing to get behind going forward?

And @pb30, do you have any thoughts on this, good or bad?

Thanks for tolerating my tangent, both of you 😃

[qaisjp]

There's also Co-authored-by: Name <email> which is really good (I prefer this for truly fresh commits as it is less impersonatey)

[42wim]

@patcon sure, I'll try to think about this.