Material-theme-jetbrains: Method icons are not working for Java

[gayanper]

The method icons are not loaded when displaying methods in outline popup.

[ChrisRM]

Woops, wrong button. You are correct, there are some issues with those icons. I'm looking into it.

[gayanper]

Its seems removing the iconProvider in plugin.xml solves the problem.

 <extensions defaultExtensionNs="com.intellij">
        <editorTabColorProvider implementation="com.chrisrm.idea.MTEditorTabColor"/>
--     <iconProvider implementation="com.chrisrm.idea.icons.MTFileIconProvider"/>
        <bundledColorScheme path="/colors/Material Theme - Lighter"/>

And i couldn't find the iconProvider in list of extension definition either at InteliJ SDK.

[gayanper]

Probably those changes will not be compatible with older Idea versions which i didn't check

[mallowigi]

Yes but by doing that you're preventing the icon replacements to work. Some of them will work though, thanks to the MTIconReplacer which would replace the original icons inside the fileTypes directory to be replaced by the project's icons. But for all new icons that weren't in this directory (you can look at them inside icons.jar) there won't be a replacement. So file types such as ruby, scss, python... will not get the new icons, basically icons that come from external plugins

[gayanper]

I guess i was only focusing java since im running the community version. My bad then i know why my PR got rejected. But i guess better to find a solution which ia based on intelij openapi extension points if possible to avoid more bugs like this in future.

[ChrisRM]

Can you try to pull the repo, build the plugin and see if the java icons work properly now, @gayanper?

[gayanper]

@ChrisRM Its still the same and now the java class icon is wrong as well which was fixed by #266.

[benj56]

Any update? Makes it impossible to see the visiblity of methods in the structure screen. I rely on it and will likely need to disable the theme until this is resolved.

The right icons seem to be visisble for a second by the way, but then all of them change to the broken one.

Thanks!

[mjdetullio]

@gayanper Thanks for the hint on the iconProvider extension being the problem

[StefanSchrass]

I still see this on:
IntelliJ IDEA 2017.1
Build #IU-171.3780.107, built on March 22, 2017

[denofevil]

@StefanSchrass updated plugin has not been published yet