Materia-theme: IME boxes and shell popups have extraneous white background box

[wuyangyu2010]

Reporter Info

• Materia version: materia-gtk-theme-20190912-1.fc30.
• GTK3 version: 3.24.11
• Distribution (and version): Fedora 30
• Desktop environment (and version): Gnome3 3.32.2
• Related application (and version):

Actual Issue

In Fedora 30, early versions of Materia had no such problems, but after updating the materia version, IME boxes and shell popups had white background borders, and different types of problems were found in testing other GTK themes.

Steps to Reproduce

1. 
   
   
   2.
   
3.

Additional Info

[cthbleachbit]

Please update the issue title to reflect the actual issue and please use English so that others may understand... Probably something like "IME boxes and shell popups have extraneous white background box".

[ghost]

Try regenerating the shell theme.
https://github.com/nana-4/materia-theme/tree/master/src/gnome-shell#installation
That removed the white borders for me.

However, this introduced weird formatting issues when searching. Only 1-2 search results are shown and the "submenu" options are cut off with a dot.

My versions:
Materia version: 9940151df24ecd92c8f1de3e511dbf6cf176d681
GTK3 version: gtk3-3.24.11-1.fc30.x86_64.rpm
Distribution (and version): Fedora 30
Desktop environment (and version): gnome-shell-3.32.2-2.fc30.x86_64.rpm
Related application (and version):

[nana-4]

Yeah, it seems @Ghostium is right.

@wuyangyu2010 I think your problem should be fixed by reinstalling Materia GDM theme. Please try it.

[nana-4]

@cthbleachbit Thanks, I've updated the issue title as you suggested :)

[nana-4]

However, this introduced weird formatting issues when searching. Only 1-2 search results are shown and the "submenu" options are cut off with a dot.

@Ghostium Strange, I couldn't reproduce it on both Xorg and Wayland.

Did you manually customize anything? From your screenshot, it looks like you have applied the gnome-shell 3.34 theme to gnome-shell 3.32.x. (I didn't carefully check, so I may be wrong.)

[ghost]

Thanks, I accidentally used 3.34 styles for 3.32.

I always thought that the install.sh script copies every version and gnome just picks the right folder, as I never really dived into how themes work. I build materia-theme in a Docker container so the gnome-shell package is not installed and the version can't be derived defaulting to $LATEST_GS_VERSION.

I did not find a CLI flag or environment variable to set the gnome version, so I just run sed in my .spec file:

sed -i 's/\${GS_VERSIONS\[-1\]}/3.32/g' install.sh

Maybe $GS_VERSION should only be set if it not already defined (so it can be passed as an environment variable). if test -z "$GS_VERSION"; then if command -v etc..

[wuyangyu2010]

@nana4 I removed Fedora's RPM installation package and cloned material theme from GitHub. After the new installation, all problems were solved. Think you!

[nana-4]

@wuyangyu2010 I think you didn't need to remove the RPM package and clone the repo; just regenerating the GDM theme should have been fine. But anyway I'm glad to hear that :)

[nana-4]

@Ghostium

I always thought that the install.sh script copies every version and gnome just picks the right folder,

Regarding GTK themes, that's true. But gnome-shell uses St toolkit instead of GTK, and it doesn't support versioned theme folders. So we need to pick a proper version of gnome-shell theme in the script.

I build materia-theme in a Docker container so the gnome-shell package is not installed and the version can't be derived defaulting to $LATEST_GS_VERSION.

Sorry I'm not familiar with Docker, so I may be wrong something but: Does that mean you have installed gnome-shell in the OS directly, not in the Docker container? If so, why don't you build materia-theme in both OS (for gnome-shell & gdm) and the Docker container (for GTK apps)?

so I just run sed in my .spec file

Can you show me all the code/description in your .spec file? Then I can understand more background :)

[nana-4]

@Ghostium Probably it would be better to talk about it in another issue. Please, use #434 to reply :)