Mapper: Trash bin icon appears in unexpected place.

[yevhenmazur]

Steps to reproduce

1. Add any template
2. Save the map and close Mapper
3. Move/rename the template file
4. Open map file and look in to Template setup window.

Actual behaviour

Expected behaviour

I like new icon, but it is suitable only for show remove/delete action. Red cross is more universal and can be used to mark removed/renamed template. I expect to see the red cross or other suitable icon in the Template setup window.

Configuration

Mapper Version: starting from cd48423c49f9005fd1b0440bfaedcc1246607c65
Operating System: All platforms

[dg0yt]

Shall we restore the cross here, or would you expect a diffent icon for a missing file?

[Zerbembasqwibo]

Red cross is fine, maybe not 100% logical since red cross in the app means delete.

[dg0yt]

I replaced the red cross (for delete) with the trash bin, but there is still the dark cross (for close): https://github.com/OpenOrienteering/mapper/blob/master/images/close.png

[lpechacek]

How about a dead smiley face? We don't have to be always serious, do we?

[Zerbembasqwibo]

https://cdn1.iconfinder.com/data/icons/leto-files/64/leto_files-58-512.png

2018-06-18 23:04 GMT+02:00 Libor Pecháček [e-mail]:

How about a dead smiley face
https://www.google.com/search?q=dead+smiley+face? We don't have to be
always serious, do we?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/OpenOrienteering/mapper/issues/1105#issuecomment-398195143,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APa4D_jav_ZS50Rd26FIY6CoZtu_r9-8ks5t-BXAgaJpZM4UkqJf
.

[Zerbembasqwibo]

Maybe better?
https://upload.wikimedia.org/wikipedia/commons/thumb/b/b2/High-contrast-image-missing.svg/2000px-High-contrast-image-missing.svg.png

2018-06-19 5:22 GMT+02:00 Sven Lundbäck [e-mail]:

https://cdn1.iconfinder.com/data/icons/leto-files/64/leto_files-58-512.png

2018-06-18 23:04 GMT+02:00 Libor Pecháček [e-mail]:

How about a dead smiley face
https://www.google.com/search?q=dead+smiley+face? We don't have to be
always serious, do we?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/OpenOrienteering/mapper/issues/1105#issuecomment-398195143,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APa4D_jav_ZS50Rd26FIY6CoZtu_r9-8ks5t-BXAgaJpZM4UkqJf
.

[lpechacek]

@Zerbembasqwibo, both look good to me. The second maybe better fits current Mapper look. Mind filing a pull request with your preferred choice?

[Zerbembasqwibo]

I don't know how to do pull requests.

2018-06-19 10:24 GMT+02:00 Libor Pecháček [e-mail]:

@Zerbembasqwibo https://github.com/Zerbembasqwibo, both look good to
me. The second maybe better fits current Mapper look. Mind filing a pull
request with your preferred choice?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OpenOrienteering/mapper/issues/1105#issuecomment-398317137,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APa4D2eoTi0vyLXD6hLFLO2Ph7j8Fjmlks5t-LU9gaJpZM4UkqJf
.

[lpechacek]

I didn't know either until I learned it. There is fine documentation on that.

[dg0yt]

Note that we can't accept artwork without knowing original copyright.

Alternatively, this is a plain composition of icons we already use:

[mlerjen]

How about a simple question mark? A missing template requires resolving action by the user. (to re-establish the linking).

[dg0yt]

Looking at the icon naming specification again (#1085), it seems that we need either the emblem-unreadable or the image-missing icon. Cf. https://commons.wikimedia.org/wiki/Comparison_of_icon_sets

[lpechacek]

@dg0yt, working on this one?

[dg0yt]

Not at the moment. What I would do is trying to make the dark cross available under an image-missing alias.

[ollesmaps]

The dustbin icon works perfectly. Thank you!