Manageiq: chargeback: problems on Rate edition

[amaurygonzalez]

Revisiting the new changes in the master branch with @tledesma we saw unexpected behaviors in the chargeback:

1. Failed to add a new rate: _undefined method `chargeback_rate_detail_currency_id' for nil:NilClass [chargeback/x_button]
2. After copying a rate, we see in the show view of new rate the units expressed like "Megahertz, Megabytes ....". Should be shown as the original, with the measures display name "MHz, MB"
3. When a rate is copied, the name of the new rate it is not show by adding at the name of the original rate the word "copy", so it is now necessary to change the name by hand.

4. When you want to edit a copied rate, the measures selectors (Per Unit) don't appear because the "chargeback_rate_detail_measure_id" are empties. I realized that "metric" are empties too in the database.

[h-kataria]

@gtanzillo @jrafanie i think the first issue is result of removal of code that read yaml and initialized chargeback_rate_details for new records. Other 2 looks like minor changes/fixes result of changes that were made to remove AR Objects from session. I can take a look at 2 & 3.

[gtanzillo]

Thanks @h-kataria! @lpichler can you please take a look at issue 1 since I won't be available next week? I removed the loading of the yaml file in this commit - https://github.com/ManageIQ/manageiq/pull/5828/commits/08fe0a24113648051d839cf931420479413f6bd2. Didn't seem necessary since that happens during seeding.

[h-kataria]

Reopenining, not all issues reported in this issue are fixed yet.

[tledesma]

@lpichler @h-kataria I have also noticed that when you want to edit a copied rate, the measures selectors (Per Unit) don't appear because the "chargeback_rate_detail_measure_id" are empties. I realized that "metric" are empties too in the database.

[lpichler]

@tledesma I can take a look on it also. Call it as point 4. thanks

[tledesma]

@lpichler @h-kataria If we want to add a new tier, we cannot do it unless it is the first one.

Also, when I save a edited rate, the changes are not saved.
I don't know if it would be better to open other issue for them.

[lpichler]

@tledesma yes I noticed it before a while also(5), it is for rates where we can select any unit (not for countable)
related to this thing is another bug.

that when editing exiting one, and I will change unit, then it is not stored. (6)

I don't what is better but issues are related, so we can keep it there and state them in first comment
and we can use checkboxes(task list) to see what is fixed.

[tledesma]

@lpichler yes, you are right, so @amaurygonzalez can you please add them?

[lpichler]

@amaurygonzalez can you open it please again ? It seems tthat it was automaticly closed after merge. Thanks!

[amaurygonzalez]

@lpichler. I can't reopen it!. I think i don't have privilege for this