Manageiq: [Jansa-1] Provisioning Virtual Machines : Custom Specifications not retrieved from provider

[gpavinteractiv]

Since upgrading to Jansa-1
Either with oVirt and vSphere providers, I can not retrieve custom specifications while provisioning VM from templates:

Compute>Infrastructure>Virtual Machines>Templates>Provision Virtual Machines>Customize:
Custom Specification : Empty

[agrare]

@gpavinteractiv this sounds like a duplicate of https://github.com/ManageIQ/manageiq-providers-vmware/issues/611 which was backported to jansa but not by the jansa-1 release tag.
Try applying https://github.com/ManageIQ/manageiq-providers-vmware/pull/614 and see if that resolves the issue

[Nikkurer]

I've met same error at jansa-1.

@gpavinteractiv this sounds like a duplicate of ManageIQ/manageiq-providers-vmware#611 which was backported to jansa but not by the jansa-1 release tag.
Try applying ManageIQ/manageiq-providers-vmware#614 and see if that resolves the issue

I've applied this MR to jansa-1. But there is no such dir "spec". Am I missing something?

[root@miq09 manageiq-providers-vmware-e79a5906de0c]# pwd
/opt/manageiq/manageiq-gemset/bundler/gems/manageiq-providers-vmware-e79a5906de0c
[root@miq09 manageiq-providers-vmware-e79a5906de0c]# ls
app  bin  CHANGELOG.md  collector.diff  config  content  Gemfile  lib  LICENSE.txt  locale  manageiq-providers-vmware.gemspec  Rakefile  README.md  tools
[root@miq09 manageiq-providers-vmware-e79a5906de0c]# find / -name spec -type d
/usr/lib/node_modules/npm/node_modules/json-schema-traverse/spec
/opt/manageiq/manageiq-gemset/bundler/gems/manageiq-ui-classic-ed9e3142e2a1/app/javascript/spec
/opt/manageiq/manageiq-gemset/gems/bundler-2.1.4/lib/bundler/templates/newgem/spec
/opt/manageiq/manageiq-gemset/gems/dry-types-1.4.0/lib/dry/types/spec
/opt/manageiq/manageiq-appliance/spec
[root@miq09 manageiq-providers-vmware-e79a5906de0c]# ls -l /opt/manageiq/manageiq-appliance/spec
total 8
-rw-r--r--. 1 root root 3190 Sep 14 22:34 evm_watchdog_spec.rb
-rw-r--r--. 1 root root  106 Sep 14 22:34 spec_helper.rb

[agrare]

You can ignore the spec dir we strip it out of released versions since it holds our automated tests and isn't used at all in production

[Nikkurer]

You can ignore the spec dir we strip it out of released versions since it holds our automated tests and isn't used at all in production

Thank you for reply. I was confused because found this dir at ivanchuk-7 appliance.
Anyway. I've applied this patch to the jansa-1 and still don't see specifications.

[agrare]

@Nikkurer I applied that PR to a jansa-1 appliance and I'm seeing customization specs being collected

irb(main):002:0> ManageIQ::Providers::Vmware::InfraManager.first.customization_specs
=> #<ActiveRecord::Associations::CollectionProxy [#<CustomizationSpec id: 1, name: "simaishi-custom1", ems_id: 2, typ: "Linux", description: "", last_update_time: nil, spec: {"dynamicProperty"=>[], "options"=>{"dynamicProperty"=>[]}, "identity"=>{"dynamicProperty"=>[], "hostName"=>{"dynamicProperty"=>[], "base"=>"simaishi-custom"}, "domain"=>"cloudforms.lab.eng.rdu2.redhat.com", "timeZone"=>"America/Los_Angeles", "hwClockUTC"=>true}, "globalIPSettings"=>{"dynamicProperty"=>[], "dnsSuffixList"=>[], "dnsServerList"=>[]}, "nicSettingMap"=>[{"dynamicProperty"=>[], "adapter"=>{"dynamicProperty"=>[], "ip"=>{"dynamicProperty"=>[]}, "gateway"=>[], "dnsServerList"=>[]}}], "encryptionKey"=>[]}, created_at: "2020-10-21 16:08:52", updated_at: "2020-10-21 16:08:52">]>

[chessbyte]

@Fryguy @simaishi would it make sense to build a Jansa fixpack, if there are enough bugs to address?

[Nikkurer]

@Nikkurer I applied that PR to a jansa-1 appliance and I'm seeing customization specs being collected

irb(main):002:0> ManageIQ::Providers::Vmware::InfraManager.first.customization_specs
=> #<ActiveRecord::Associations::CollectionProxy [#<CustomizationSpec id: 1, name: "simaishi-custom1", ems_id: 2, typ: "Linux", description: "", last_update_time: nil, spec: {"dynamicProperty"=>[], "options"=>{"dynamicProperty"=>[]}, "identity"=>{"dynamicProperty"=>[], "hostName"=>{"dynamicProperty"=>[], "base"=>"simaishi-custom"}, "domain"=>"cloudforms.lab.eng.rdu2.redhat.com", "timeZone"=>"America/Los_Angeles", "hwClockUTC"=>true}, "globalIPSettings"=>{"dynamicProperty"=>[], "dnsSuffixList"=>[], "dnsServerList"=>[]}, "nicSettingMap"=>[{"dynamicProperty"=>[], "adapter"=>{"dynamicProperty"=>[], "ip"=>{"dynamicProperty"=>[]}, "gateway"=>[], "dnsServerList"=>[]}}], "encryptionKey"=>[]}, created_at: "2020-10-21 16:08:52", updated_at: "2020-10-21 16:08:52">]>

Sorry @agrare it was my fault. Forgot patch for parser.rb. Your patch is working.

[agrare]

Thanks for testing @Nikkurer ! I'll go ahead and mark this resolved