Live-share: Should provide complete FileSystemProvider for VS Code extensions

[tamuratak]

When uri points to vsls:///path/filename, vscode.workspace.fs.readFile(uri) does not work on the guest machine for binary files.

Live Share should provide a complete FileSystemProvider supporting binary files.

I am a contributor to LaTeX Workshop, VS Code extension for LaTeX editing. @daytonellwanger has made a PR that made the extension support Live Share. However, the PR makes the maintenance of the extension more difficult, putting code fragments for Live Share everywhere in the codebase.

I have found that if FileSystemProvider by Live Share supports binary files, the PR can get much more straightforward. I cannot see why it doesn't support binary files. Virtual filesystems provided by FileSystemProvider are not intended only for text files.

Moreover stat.size returned by vscode.workspace.fs.stat(uri) is undefined. That should be fixed too.

[Yosoyfr]

F

[rodrigovaras]

@daytonellwanger , what is the state of the binary support on our file system provider implementation, do we vere face some limitations on our extension due to this?

[lostintangent]

Closing this as a duplicate of #1895, so that we can consolidate the discussion. In general, we’ll plan to reassess support for binary files in Live Share, once folks are back from the holidays.