Live-share: [VS Code] "Go to definition" no longer works

[willresen]

Issue Type: Bug

When using the context menu "Go to Defintion", nothing happens. When hitting F12, I get "Cannot read property 'startLineNumber' of undefined". This appears to be happening project wide - worked fine until the latest VS Code update. Please help!

Extension version: 1.0.2236
VS Code version: Code 1.45.1 (5763d909d5f12fe19f215cbfdd29a91c0fa9208a, 2020-05-14T08:27:35.169Z)
OS version: Windows_NT x64 10.0.18363

System Info

|Item|Value|
|---|---|
|CPUs|AMD Ryzen 7 2700X Eight-Core Processor (16 x 3700)|
|GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled|
|Load (avg)|undefined|
|Memory (System)|31.95GB (24.07GB free)|
|Process Argv|-n C:\Users\Will Resen\AppData\Local\Temp\vsliveshare\tmp-A20F47FE72F7DEA9BABAE26AB94AB14622A7\Visual Studio Live Share.code-workspace|
|Screen Reader|no|
|VM|0%|

[daytonellwanger]

@aletsdelarosa could you have a look?

[daytonellwanger]

@willresen , does this only happen for a specific language? A specific project? Or it's universally broken?

[IlyaBiryukov]

Thanks for reaching out. Can you give us more details about your scenario? Also, your logs may provide us with helpful information. You can access them via the Live Share: Export Logs command from the command palette (ctrl + shift + p) and attach them to this issue.

[willresen]

@daytonellwanger @IlyaBiryukov I apologize for the delay. This is occurring for TypeScript definitions in all of my current projects when remotely accessing my machine via Live Share. When right clicking and clicking "Go to Definition", the inline window appears but is stuck on "Loading...". Is there a way I can see the content of these logs before sharing? It appears my access to the zip folder that is generated is being denied.

[daytonellwanger]

Thanks @willresen , no need for your logs just yet. Let me see if I can repro.. that'd be the easiest way for us to investigate.

[daytonellwanger]

Yup, it repros 😟. We'll have a look!

[willresen]

@daytonellwanger Any updates on this yet? Still broken for me :(

[daytonellwanger]

@aletsdelarosa is looking into it.

[TheHandsomeCoder]

Hey folks, wanted to weight in and say that I'm also seeing this issue. Is there any updates?

[daytonellwanger]

I believe @aletsdelarosa has gotten to the bottom of it and is putting together the fix right now, so hopefully should be out the week after next.

[TheHandsomeCoder]

Hey @aletsdelarosa and @daytonellwanger just wondering if there was there any update on this or is there something that could be contributed to helping solve the issue?

[aletsdelarosa]

Hello @TheHandsomeCoder it is in PR now. It should be working next week

[daboross]

Hi! Any update on this?

I can try to provide any more debug data if any is needed. I've got it fully reproducible on my machine, and would be happy to help if there's anything I can do or any more logs I can provide.

[willresen]

I would love an update as well, this is still an issue. Happy to provide logs or testing.

[11joselu]

Maybe this window log help

[2020-09-09 15:16:15.373] [renderer3] [error] ENOENT: no such file or directory, unlink '/home/<USER_HOST>/.local/share/vsliveshare/cascade.json': Error: ENOENT: no such file or directory, unlink '/home/<USER_HOST>/.local/share/vsliveshare/cascade.json'
[2020-09-09 15:16:33.246] [renderer3] [error] Unable to read file '/undefined' (Error: Unable to resolve non-existing file '/undefined'): Error: Unable to read file '/undefined' (Error: Unable to resolve non-existing file '/undefined')
    at b.doReadAsFileStream (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1730:591)
    at async M.doRead (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6506:9)
    at async M.readStream (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6505:661)
    at async e.loadFromFile (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6419:488)
    at async w.resolve (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6501:865)
    at async b.createModelReference (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6431:875)
[2020-09-09 15:16:33.853] [renderer3] [error] Cannot read property 'startLineNumber' of undefined: TypeError: Cannot read property 'startLineNumber' of undefined
    at Function.collapseToStart (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:660:950)
    at W._openReference (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2753:929)
    at W._onResult (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2753:604)
    at file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2753:246
[2020-09-09 15:16:42.416] [renderer3] [error] Unable to read file '/undefined' (Error: Unable to resolve non-existing file '/undefined'): Error: Unable to read file '/undefined' (Error: Unable to resolve non-existing file '/undefined')
    at b.doReadAsFileStream (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1730:591)
    at async M.doRead (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6506:9)
    at async M.readStream (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6505:661)
    at async e.loadFromFile (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6419:488)
    at async w.resolve (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6501:865)
    at async b.createModelReference (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6431:875)
[2020-09-09 15:38:10.531] [renderer3] [error] Unable to read file '/undefined' (Error: Unable to resolve non-existing file '/undefined'): Error: Unable to read file '/undefined' (Error: Unable to resolve non-existing file '/undefined')
    at b.doReadAsFileStream (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1730:591)
    at async M.doRead (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6506:9)
    at async M.readStream (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6505:661)
    at async e.loadFromFile (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6419:488)
    at async w.resolve (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6501:865)
    at async b.createModelReference (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6431:875)
[2020-09-09 15:41:35.080] [renderer3] [error] Unable to read file '/undefined' (Error: Unable to resolve non-existing file '/undefined'): Error: Unable to read file '/undefined' (Error: Unable to resolve non-existing file '/undefined')
    at b.doReadAsFileStream (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1730:591)
    at async M.doRead (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6506:9)
    at async M.readStream (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6505:661)
    at async e.loadFromFile (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6419:488)
    at async w.resolve (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6501:865)
    at async b.createModelReference (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6431:875)
[2020-09-09 15:41:36.827] [renderer3] [error] Unable to read file '/undefined' (Error: Unable to resolve non-existing file '/undefined'): Error: Unable to read file '/undefined' (Error: Unable to resolve non-existing file '/undefined')
    at b.doReadAsFileStream (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1730:591)
    at async M.doRead (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6506:9)
    at async M.readStream (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6505:661)
    at async e.loadFromFile (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6419:488)
    at async w.resolve (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6501:865)
    at async b.createModelReference (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6431:875)

[daytonellwanger]

I believe @aletsdelarosa has had a fix for a while. Alex, is it ready to ship?

[super-tuple]

@aletsdelarosa Any updates?

[TheHandsomeCoder]

Hey @aletsdelarosa / @daytonellwanger , just checking in if there has been any movement on this bug? Again if there's anything we can do to assist with getting it over the line please let us know, it's an incredibly useful feature.

[TheHandsomeCoder]

Hey @aletsdelarosa / @daytonellwanger, Sorry to be a bother on this, but circling back as it's still an issue :/ Is there any update you could share on the on going work?

[daytonellwanger]

Yes! @smvanderweide is currently working on this issue, and it should be resolved soon. Thank you for your patience!

[slushnys]

My Christmas spirit tells me they're preparing us a Christmas present 🎁

[TheHandsomeCoder]

Hey @daytonellwanger, sorry to keep pushing on this, but I was wondering if there was any updates

[daytonellwanger]

Hey @TheHandsomeCoder , no worries. Sorry for the delay. It will be fixed in our release this week! I'll ping this thread then to make sure it's finally resolved. Thanks for your patience.

[lostintangent]

The fix for this has now been deployed to the marketplace. Thanks again for your patience and help in resolving this issue. Please let us know if you run into any issues, otherwise, I'll go ahead and close this as resolved 👍