Live-share: AccessToken are not saved on wsl installation
Product and Version [VS/VSCode]: 1.40.0
OS Version [macOS/Windows]: Windows 10 (Build 18980.1)
Live Share Extension Version: 1.0.1123
Target Platform or Language [e.g. Node.js]: node
Steps to Reproduce / Scenario:
- Install extension into wsl
- Login via Github or Microsoft
- Enter Token
- See that your are loged in on the status bar
- Reload Window
- You are no longer logged in
I'm using archlinux, but the same happened to my colleage who is using ubuntu 18.04.
enko
All 4 comments
Thanks for reporting and the clear repro steps. @legomushroom , any initial thoughts on what may be happening?
daytonellwanger
on 12 Nov 2019
The keytar requests should be routed to the client-side, so in theory, it should work. @Chuxel did you see this before?
Update:
I just realized that we don't use the keytar hence it does not work. That will be fixed when we move to the new auth flow that uses the keytar module.
legomushroom
on 12 Nov 2019
Is there a ticket for the new auth flow that I can subscribe?
enko
on 13 Nov 2019
@enko please follow the #2982 issue, which talks about the workaround currently and will be closed when we have the new workflow implemented.
Thanks!
Closing this issue now.
fubaduba
on 15 Nov 2019
Related issues
squillace
路
3Comments
dec0dOS
路
4Comments
jpopadak
路
3Comments
csharpfritz
路
4Comments
Chuxel
路
4Comments
Most helpful comment
The keytar requests should be routed to the client-side, so in theory, it should work. @Chuxel did you see this before?
Update:
I just realized that we don't use the keytar hence it does not work. That will be fixed when we move to the new auth flow that uses the keytar module.