Lila: Rename 'Close' button to 'Close Team'

Created on 9 Sep 2020  路  4Comments  路  Source: ornicar/lila


I was making edits to a new team I formed today. I was pretty tired and it wasn't going very well. So I decided to cancel what I was doing and come back to it later.

The first thing that caught my eye was the red CLOSE button. I assumed that closed the editing dialog. And when the alert came along, I assumed it was something along the lines of "unsaved edits won't be saved". But the time I read what it said, I had already pressed the confirm button.

Although there is a tool tip and a conformation. But at first glance it's not obvious at all. I feel better name would go a long way in making it less ambiguous what the button does. The button looks suspiciously similar to a close dialogue button
image

Something 'Close Team' possible changing the logo as well (to the caution symbol), would make it's function obvious right from the start.
image

Most helpful comment

Hey @ddugovic I'm def going to push one soon. Since this is a fairly simply change, and hacktoberfest is underway. I thought of using it as a an example to show new members of my college's foss what goes into contributing to foss projects (Fork-branch workflow, writing proper commits, submitting a PR and all that jazz)

All 4 comments

I'd be happy to submit a PR if this change is approved.

Something like the 'Cancel the Tournament' button
image

@JadeMaveric If it's not too much trouble, please submit a PR so this issue isn't forgotten.

Hey @ddugovic I'm def going to push one soon. Since this is a fairly simply change, and hacktoberfest is underway. I thought of using it as a an example to show new members of my college's foss what goes into contributing to foss projects (Fork-branch workflow, writing proper commits, submitting a PR and all that jazz)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ddugovic picture ddugovic  路  4Comments

DVRazor picture DVRazor  路  3Comments

thomas-daniels picture thomas-daniels  路  4Comments

nojoking picture nojoking  路  4Comments

nikolatzotchev picture nikolatzotchev  路  3Comments