Lila: User games download UI

Created on 11 Jan 2020  路  10Comments  路  Source: ornicar/lila

A form page to help build download URLs for this API: https://lichess.org/api#operation/apiGamesUser

I think something like this already exists in the wild, but it would be nice to make part of lichess.

Use the existing form CSS, like on https://lichess.org/games/search or https://lichess.org/tournament/new

The form is never submitted, instead it generates download URLs on client side with JS/TS

feature good first issue wanted

Most helpful comment

I'm going to take a crack at this if that's alright.

All 10 comments

A bit like this (but prettier) https://lichessgamedownload.netlify.com/

I have a custom search application ( https://fbserv.herokuapp.com/games.html?username=penguingim1 ) and I received feedback over time and know what users really want from a game search.

May be this would be useful information:

  • result by the player rather than color ( so games won by me, rather than games won by white )
  • results against titled players ( I remember beating a titled player, but can't find this game )
  • filtering by rating of opponent ( rather than average rating of the game )
  • searching games by opening moves ( I provide search both ECO and custom move list )

Hi,

Sorry to bother you.

I would be happy to claim the issue if it is still available. If that is true, I have a few questions :

  • Are there any specific technologies which the issue requires? (I have never worked with Scala or really the backend, so I would not be much help if the issue required those technologies - the issue does not have "no Scala" label on it).
  • Is there any linters, styled guides or development practices that I should use in the development process (such as airbnb Javascript style guide, for example)?
  • Would you like me to include tests for the component?

Sorry for many the questions.

Hi,

I am unable to commit to the issue (if it is open) due to other commitments. If this issue was seen to be claimed by me, it should be open for another person to do.

I'm going to take a crack at this if that's alright.

Soo I'm trying to make a form and am struggling to add input boxes to it. I'm trying to do this

form3.input(form("username"))(tpe := "text")

but get this error

[E]      type mismatch;
[E]       found   : scalatags.Text.TypedTag[String]                                                     
[E]       required: play.api.data.Field                                                                 
[E]      L25:               form3.input(form("username")("b"))(tpe := "text")

I copy/pasted that line I used from a line I found in app/views/search/user.scala, so I'm not really sure why that one compiles fine but mine doesn't. What am I missing?

Hey If nobody is working on this, can I take this up and give this a try? This would be my first attempt at lila-development if that is okay.

Related PR (WIP, not sure what the status of this is): #5917

It seems that the game search page on the user profile has most if not all of the form functionality needed UI-wise:

Screenshot from 2020-11-11 11-45-23

I'm not sure if this game search UI was introduced before/after this issue was made, but regardless, it seems like it would be sufficient to add a download button above the search results, somewhat like this (with proper styling ofc):

downloadgames

Thoughts?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

isaacl picture isaacl  路  4Comments

nikolatzotchev picture nikolatzotchev  路  3Comments

ShRyDeR picture ShRyDeR  路  3Comments

Assios picture Assios  路  3Comments

marmistrz picture marmistrz  路  3Comments