On black's turn, a computer suggested drop is shown as a circled semitransparent black piece. When black moves, the drop suggestion momentarily switches colors to a white piece before disappearing.
isaacl
All 14 comments
@niklasf
isaacl
on 29 Dec 2016
So far I am not able to reproduce this. Maybe I should try a specific position?
niklasf
on 29 Dec 2016
I can reproduce 100% of time, and it doesn't actually matter which side is moving. If the engine suggests a drop and a move is made, the drop suggestion briefly flashes the other color before disappearing. Doesn't matter whether the move is the suggestion or some other move.
isaacl
on 29 Dec 2016
hmm, maybe was recently fixed? I last checked on my home computer a couple days ago, will follow up shortly when I get home.
isaacl
on 29 Dec 2016
please reopen, problem still exists.
Video of issue, OS X chrome 56.
isaacl
on 15 Jan 2017
Niklas helped me investigate this today. The issue is in autoshape.js::compute, which:
- gets suggestion color from chessground instead of deriving from ceval ply
- doesn't verify ceval ply matches board ply before displaying a suggestion
This issue affects promotion suggestions and drops. Regular moves do not include a color in the suggestion, so do not flip. Nevertheless, the UI might become more responsive, even for regular move suggestions, if autoshape hid the suggestion as soon as a move was made (and ply didn't match ceval), instead of waiting for a ceval callback. Here's a relevant log snippet, from analyse/ctrl.js::setAutoshape, showing the color flip
computeAutoShapes [{"orig":"b5","brush":"paleBlue"},{"orig":"b5","piece":{"color":"white","role":"queen","scale":0.8}}]
computeAutoShapes [{"orig":"b5","brush":"paleBlue"},{"orig":"b5","piece":{"color":"black","role":"queen","scale":0.8}}]
Related: #2307, #2531
isaacl
on 15 Jan 2017
Niklas fixed it.
ornicar
on 16 Jan 2017
These were two different issues. I am on it though
niklasf
on 16 Jan 2017
Tough luck. There ~is~ might be one more case to be fixed (which is when the PV is not hovered).
Edit: Maybe ... I didn't manage to cause the glitch without hovering the PV. @isaacl: Can you please give it another try on latest master or once the fix is deployed?
niklasf
on 16 Jan 2017
Even with logging the auto shapes (let alone visually) I couldn't see anything wrong. @isaacl If it's different for you, please let me know.
niklasf
on 16 Jan 2017
I saw this yesterday, and was able to reproduce about 30% of the time when I clicked on the ceval drop suggestion. I guess it's not fully fixed?
isaacl
on 23 Feb 2017
https://www.twitch.tv/videos/135833545?t=01h36m27s bishop color on b5
isaacl
on 16 Apr 2017
It's worth checking if this is still an issue after the ui/analyse rewrite.
niklasf
on 4 Jul 2017
OK I'll reopen if I see it again
isaacl
on 16 Jul 2017
Related issues
ShRyDeR
路
3Comments
Cristian-A
路
3Comments
serversideapps
路
3Comments
nojoking
路
4Comments
thomas-daniels
路
4Comments