Light-client: CodeClimate checks do not seem to work any more

[christianbrb]

Description

After reading #2147 I have checked CodeClimate and the code quality seemed to get worse within the last 2 months.

It does not seem to get checked any more within a PR (see eg. https://github.com/raiden-network/light-client/pull/2146).

Acceptance criteria

• Every PR is checked

Tasks

• [ ] Check the configuration (see https://docs.codeclimate.com/docs/workflow)

[christianbrb]

CodeClimate was stuck. Removed from the required checks. Maybe this was due to @kelsos leaving the team (token or oAuth?).

[kelsos]

@christianbrb Was I the one that created the codeclimate configuration?

[kelsos]

At least from what I see, I cannot access the repo settings for the projects on code climate anymore as excepted. Maybe you can go to the site log in with the github account and check the repo settings tab.

https://docs.codeclimate.com/docs/github-pull-requests#pull-request-statuses

The screenshot is from one of my own projects that has codeclimate activated.

Maybe they changed something that requires extra actions

[christianbrb]

@kelsos Great :) Thanks for the quick feedback :)

[palango]

I enabled CodeClimate again for the light client repository. Looks like that now:

Looks like that for me now. However, I still don't see the according check in the GitHub settings. @kelsos Do you remember how you enabled that?

[palango]

It works in https://github.com/raiden-network/light-client/pull/2197

According to the requirements that's all to do. Is there anything more that used to be done @christianbrb ? The technical dept is still higher than in summer.

[kelsos]

Out of curiosity @palango any idea why it stopped working, was it because I left the organization?

[palango]

Out of curiosity @palango any idea why it stopped working, was it because I left the organization?

No, I don't know. Andre removed the branch check at some point because it wasn't working, but maybe it really was disabled because you left the team.

[palango]

Done with the check marked as required for PRs to master.