Light-client: Identify inconsistencies between design and implementation

Created on 5 Sep 2019  路  6Comments  路  Source: raiden-network/light-client

Description

Compare design and already implemented screens and define changes that must be made; if possible, implement them as well.

Acceptance criteria

  • Both design and implementation must be syncrhonised.
  • When design and implementation look different, it must be decided whether we want to fine-tune them (bring them to 100%-100%) or whether we leave them as they are.

Tasks

  • [x] @nephix and @roy-castrillo hold meeting to compare design vs implementation
  • [x] @nephix and @roy-castrillo make list of inconsistencies and prioritize them in order of importance and feasibility to implement during next iteration.
dApp 馃摫 Design 馃帹

All 6 comments

@roy-castrillo Do you still work on this issue or can we close it?

@christianbrb it's still something I'd like to do before leaving. Maybe I could arrange a meeting with @nephix?

@roy-castrillo sure, how about next Thursday?

Meeting notes:

  • Connected tokens:

    • Wrong letter spacing on buttons in dropdown

  • Replace start screen with transfer screen (#519)
  • Find meaningful app header labels (e.g. currently Raiden dApp or Send on transfer screen)
  • Token overlay

    • Wrong icon spacing

  • Transfer screen

    • Missing > arrow in call to action button

  • Transfer stepper

    • Missing > arrow in call to action button

    • PFS selection

    • Maybe not pre-select a route?

    • Show amount to be transfered in continue button, after PFS got selected

    • Remove separating header line from PFS selection table

    • Add more spacing between rows in PFS table

    • Maybe use same > arrow from action button for table sorting, but rotate up and down

    • Select Route

    • Remove separating header line from PFS selection table

    • Add more spacing between rows in PFS table

    • Maybe use same > arrow from action button for table sorting, but rotate up and down

    • Confirmation screen

    • Proposal TBD by @roy-castrillo & @taleldayekh

  • Route payment overlay (implemented as part of #463)

CC @christianbrb

@nephix Thanks :)

Could you split the comment into separate issues? Maybe summarizing the very small changes into one issue.

@christianbrb I have created the following tickets:

542

543

544

I'm closing this ticket, because we've identified the inconsistencies

Was this page helpful?
0 / 5 - 0 ratings

Related issues

MrCleanerPickerUpper picture MrCleanerPickerUpper  路  6Comments

christianbrb picture christianbrb  路  6Comments

christianbrb picture christianbrb  路  3Comments

kelsos picture kelsos  路  6Comments

nephix picture nephix  路  4Comments