Lbry-desktop: Full screen Button Stops Working After Double Click

[ElectronEsq]

The Issue

Full screen button stops working after double clicking it. You have to use the keyboard or double click again to get out of it.

Steps to Reproduce

Double click a video to make full screen. Then try coming out of full screen using the full screen icon in the bottom right.

Expected Behavior

The icon should make the screen size normal again.

Actual Behavior.

Does nothing.

System Configuration

App | 0.31.1
Daemon (lbrynet) | 0.34.0
Windows 10

[tzarebczan]

Thanks for filing and vv181 for finding this! Strange that it works fine if you full screen using the button, or exit full screen when double clicking!

[vv181]

the resize icon is changed though, but the video isn't resized.

[btzr-io]

Is this still an issue ?

[btzr-io]

I can't recreate this issue in the latest version:

App | 0.32.2
-- | --
Daemon (lbrynet) | 0.37.1
Platform | Linux (Linux-4.15.0-48-generic-x86_64-with-debian-stretch-sid)

[btzr-io]

Also tested with the new player on: https://beta.lbry.tv/

[btzr-io]

probably a windows issue ?

[vv181]

probably a windows issue ?

I discovered the bug on Arch.

Recently I haven't yet upgraded nor tried the latest LBRY app. Will do it if I've some free time.

[vv181]

Is this still an issue ?

App | 0.32.2
Daemon (lbrynet) | 0.37.1
Platform | Linux (Linux-5.1.4-arch1-1-ARCH-x86_64-with-arch)

I can confirm the issues haven't yet fixed.

[vv181]

Tested on both Windows and Linux the issue still occurs, except on the https://beta.lbry.tv/ its work as expected.

[btzr-io]

@vv181 Thanks for testing this issue, It's probably a bug on electron but new video player should fix this issue :+1:

[btzr-io]

Small update on this issue, the old toggleFullscreen was wrong implemented and it was requesting fullscreen mode for the container instead of the video element.

This should be fixed on this branch: https://github.com/lbryio/lbry-desktop/tree/fullscreen